Skip to content

Commit 02fe821

Browse files
committed
test: load common.js to test for global leaks
common.js contains code that checks for variables leaking into the global namespace. Load common.js in all tests that do not intentionally leak variables. PR-URL: #3095 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 9bd26e7 commit 02fe821

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+48
-0
lines changed

test/parallel/test-arm-math-exp-regress-1376.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// See https://github.com/nodejs/node/issues/1376
33
// and https://code.google.com/p/v8/issues/detail?id=4019
44

5+
require('../common');
56
Math.abs(-0.5);
67
Math.acos(-0.5);
78
Math.acosh(-0.5);

test/parallel/test-bad-unicode.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert'),
34
exception = null;
45

test/parallel/test-beforeexit-event-exit.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34

45
process.on('beforeExit', function() {

test/parallel/test-child-process-fork-exec-argv.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var child_process = require('child_process');
45
var spawn = child_process.spawn;

test/parallel/test-cluster-disconnect-before-exit.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var cluster = require('cluster');
34

45
if (cluster.isMaster) {

test/parallel/test-cluster-disconnect-unshared-tcp.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
process.env.NODE_CLUSTER_SCHED_POLICY = 'none';
34

45
var cluster = require('cluster');

test/parallel/test-cluster-disconnect-with-no-workers.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var cluster = require('cluster');
45

test/parallel/test-cluster-worker-events.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var cluster = require('cluster');
45

test/parallel/test-cluster-worker-forced-exit.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var cluster = require('cluster');
45
var net = require('net');

test/parallel/test-cluster-worker-isconnected.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var cluster = require('cluster');
34
var assert = require('assert');
45
var util = require('util');

test/parallel/test-cluster-worker-isdead.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var cluster = require('cluster');
34
var assert = require('assert');
45
var net = require('net');

test/parallel/test-domain-enter-exit.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22
// Make sure the domain stack is a stack
33

4+
require('../common');
45
var assert = require('assert');
56
var domain = require('domain');
67

test/parallel/test-domain-nested.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22
// Make sure that the nested domains don't cause the domain stack to grow
33

4+
require('../common');
45
var assert = require('assert');
56
var domain = require('domain');
67

test/parallel/test-domain-safe-exit.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22
// Make sure the domain stack doesn't get clobbered by un-matched .exit()
33

4+
require('../common');
45
var assert = require('assert');
56
var domain = require('domain');
67

test/parallel/test-event-emitter-errors.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var EventEmitter = require('events');
34
var assert = require('assert');
45

test/parallel/test-freelist.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
// Flags: --expose-internals
44

5+
require('../common');
56
const assert = require('assert');
67
const freelist = require('freelist');
78
const internalFreelist = require('internal/freelist');

test/parallel/test-http-client-read-in-error.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var net = require('net');
34
var http = require('http');
45
var util = require('util');

test/parallel/test-next-tick-doesnt-hang.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* does not hang the event loop. If this test times out it has failed.
55
*/
66

7+
require('../common');
78
process.nextTick(function() {
89
// Nothing
910
});

test/parallel/test-path-parse-format.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var path = require('path');
45

test/parallel/test-process-argv-0.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var path = require('path');
34
var assert = require('assert');
45
var spawn = require('child_process').spawn;

test/parallel/test-process-binding.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34

45
assert.throws(

test/parallel/test-process-exec-argv.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var spawn = require('child_process').spawn;
45

test/parallel/test-process-exit-recursive.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34

45
// recursively calling .exit() should not overflow the call stack

test/parallel/test-readline-interface.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var readline = require('readline');
45
var EventEmitter = require('events').EventEmitter;

test/parallel/test-readline-keys.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var EventEmitter = require('events').EventEmitter;
34
var PassThrough = require('stream').PassThrough;
45
var assert = require('assert');

test/parallel/test-readline-set-raw-mode.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var readline = require('readline');
45
var Stream = require('stream');

test/parallel/test-readline-undefined-columns.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22

3+
require('../common');
34
const assert = require('assert');
45
const PassThrough = require('stream').PassThrough;
56
const readline = require('readline');

test/parallel/test-regress-GH-4256.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
process.domain = null;
34
var timer = setTimeout(function() {
45
console.log('this console.log statement should not make node crash');

test/parallel/test-regress-GH-5927.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var readline = require('readline');
45

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
'use strict';
2+
require('../common');
23
process.stdin.emit('end');

test/parallel/test-regress-GH-io-1811.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22

3+
require('../common');
34
const assert = require('assert');
45

56
// Change kMaxLength for zlib to trigger the error without having to allocate

test/parallel/test-regress-GH-node-9326.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var child_process = require('child_process');
45

test/parallel/test-repl-tab.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var util = require('util');
45
var repl = require('repl');

test/parallel/test-require-json.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34

45
try {

test/parallel/test-require-process.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34

45
var nativeProcess = require('process');

test/parallel/test-stdin-pause-resume-sync.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
console.error('before opening stdin');
34
process.stdin.resume();
45
console.error('stdin opened');

test/parallel/test-stdin-pause-resume.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
console.error('before opening stdin');
34
process.stdin.resume();
45
console.error('stdin opened');
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
'use strict';
2+
require('../common');
23
process.stdin.resume();
34
process.stdin.pause();

test/parallel/test-string-decoder-end.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// the whole buffer at once, and that both match the .toString(enc)
44
// result of the entire buffer.
55

6+
require('../common');
67
var assert = require('assert');
78
var SD = require('string_decoder').StringDecoder;
89
var encodings = ['base64', 'hex', 'utf8', 'utf16le', 'ucs2'];

test/parallel/test-sync-io-option.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22

3+
require('../common');
34
const assert = require('assert');
45
const execFile = require('child_process').execFile;
56

test/parallel/test-timer-close.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34

45
var t = new (process.binding('timer_wrap').Timer);

test/parallel/test-timers-non-integer-delay.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
* it 100%.
1616
*/
1717

18+
require('../common');
1819
var assert = require('assert');
1920

2021
var TIMEOUT_DELAY = 1.1;

test/parallel/test-timers-this.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34

45
var immediateThis, intervalThis, timeoutThis,

test/parallel/test-timers-unref-leak.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34

45
var called = 0;

test/parallel/test-timers-unrefd-interval-still-fires.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
/*
33
* This test is a regression test for joyent/node#8900.
44
*/
5+
require('../common');
56
var assert = require('assert');
67

78
var N = 5;

test/parallel/test-util-log.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var util = require('util');
45

test/sequential/test-cluster-listening-port.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var cluster = require('cluster');
45
var net = require('net');

test/sequential/test-vm-timeout-rethrow.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var assert = require('assert');
34
var vm = require('vm');
45
var spawn = require('child_process').spawn;

0 commit comments

Comments
 (0)