Skip to content

Commit

Permalink
doc,src,test: assign missing deprecation code
Browse files Browse the repository at this point in the history
PR-URL: #31674
Refs: #28396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
cjihrig committed Feb 9, 2020
1 parent a2d6f98 commit 009a9c4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -2583,8 +2583,8 @@ accordingly instead to avoid the ambigiuty.
To maintain existing behaviour `response.finished` should be replaced with
`response.writableEnded`.
<a id="DEP00XX"></a>
### DEP00XX: Closing fs.FileHandle on garbage collection
<a id="DEP0137"></a>
### DEP0137: Closing fs.FileHandle on garbage collection
<!-- YAML
changes:
- version: REPLACEME
Expand Down
2 changes: 1 addition & 1 deletion src/node_file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ inline void FileHandle::Close() {
"Please close FileHandle objects explicitly using "
"FileHandle.prototype.close(). In the future, an error will be "
"thrown if a file descriptor is closed during garbage collection.",
"DEP00XX").IsNothing();
"DEP0137").IsNothing();
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-filehandle.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ common.expectWarning({
'Warning': [
`Closing file descriptor ${fdnum} on garbage collection`
],
'DeprecationWarning': [[deprecationWarning, 'DEP00XX']]
'DeprecationWarning': [[deprecationWarning, 'DEP0137']]
});

global.gc();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-promises-file-handle-close.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ async function doOpen() {

common.expectWarning({
Warning: [[`Closing file descriptor ${fh.fd} on garbage collection`]],
DeprecationWarning: [[warning, 'DEP00XX']]
DeprecationWarning: [[warning, 'DEP0137']]
});

return fh;
Expand Down

0 comments on commit 009a9c4

Please sign in to comment.