Last builds lack Windows installers and binaries

[vsemozhetbyt]

See
https://nodejs.org/download/v8-canary/v9.0.0-v8-canary201710193971f070e9/
https://nodejs.org/download/v8-canary/v9.0.0-v8-canary201710206d75561466/

The last one with Windows items is
https://nodejs.org/download/v8-canary/v9.0.0-v8-canary20171018c5afbc57bf/

[targos]

That's because the build is broken on Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/12687/

[refack]

Also checking out

[targos]

Still failing: https://ci.nodejs.org/job/node-compile-windows/12882/

[vsemozhetbyt]

Still lack.
cc @nodejs/platform-windows?

[seishun]

CI looks fine, so it's up to @nodejs/build

[targos]

CI does not look fine. Here is the last run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/12997/

[seishun]

Ah, the dreaded parallel/test-async-wrap-uncaughtexception. See nodejs/node#16210

[targos]

Not really. It doesn't even compile.

[refack]

It's that json bug. I have a patch for that. I wanted to upstream. I'll float here.

[targos]

@refack. Thanks. If you have a working patch, feel free to push a commit on top of canary-base (in nodejs/node, not this repo). The daily job will pick it up tomorrow.

[seishun]

I see here that the last few builds were successful though: https://ci.nodejs.org/job/node-compile-windows/

[targos]

We only have one canary build per day (unless it's manually triggered). They share the same platform jobs with regular CI.

[bzoz]

nodejs/node@dfcaf28 fixed Windows compilation