This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
doc: supplement docs for Writable and Transform streams #8769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly fix and supplement the documentation for Writable#_write and Transform#_transform methods. Make it more consistent. Mention passing 'buffer' as a encoding param in case chunk is a Buffer.
|
+1 |
|
Hey @wizardzloy could you re-submit this PR to https://github.com/iojs/io.js? Someone could adopt it for you if you are not interested. |
|
@a0viedo Yes sure I'll do that |
|
This landed over in nodejs/node already. While it could land in v0.10, there's no pressing issue now that v0.10 is moving into maintenance |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly fix and supplement the documentation for Writable#_write and
Transform#_transform methods. Make it more consistent. Mention
passing 'buffer' as a encoding param in case chunk is a Buffer.