This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: i18n: reduce on-disk size with small-icu by 1MB when using ICU 54 #8707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
force-pushed
the
srl-v0.12-slimdown
branch
from
a0277bb to
8057daf
Compare
|
the source-file-exclusion only saves a few K, maybe up to 1MB in total depending on platform. May not be worth it for fragility. |
Reduces space by about 1MB with ICU 54 (over without this patch). Also trims a few other source files, but only conditional on the exact ICU version used. This is to future-proof - a file that is unneeded now may be needed in future ICUs.
srl295
force-pushed
the
srl-v0.12-slimdown
branch
from
f29b2f7 to
bfdffa7
Compare
|
as of bfdffa7 sizes are:
|
|
So this saves 1.3MiB in the windows binary with the 'new' default options. Probably worth while. In the future srl295#8 will investigate further slimdown. |
|
I'm going to merge this in another PR, into #8719 |
srl295
referenced
this pull request
in srl295/node-v0.x-archive
Nov 19, 2014
srl295
referenced
this pull request
in srl295/node-v0.x-archive
Nov 19, 2014
build: i18n: rebuild icu-small after merge of joyent#8707 * icudt54l.dat drops from 2.6MB to 1.3MB
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned this in #7676 (comment)
I'll see if I can squeeze any more space out as well.