This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy,
When you add a new
once
listener on a EventEmitter, it gets wrapped in a closure and pushed in the events hash. When this is done, you will lose the reference to the original listener and lose the abilities to remove the same listener again as the removeListener checks if the supplied functions are matching..This patch will allow us to remove the attached
once
listeners again, because closure function will now have a reference attached to him where we can check on.