This repository was archived by the owner on Apr 22, 2023. It is now read-only.
tools: add license boilerplate to check-imports.sh#6962
Closed
bnoordhuis wants to merge 2 commits intonodejs:masterfrom
Closed
tools: add license boilerplate to check-imports.sh#6962bnoordhuis wants to merge 2 commits intonodejs:masterfrom
bnoordhuis wants to merge 2 commits intonodejs:masterfrom
Conversation
I want to use this file in other projects and I don't want there to be any misconceptions about its authorship or copyright.
Make it possible to invoke the script as `./check-imports.sh foo.cc` but default to src/*.cc when invoked with no arguments for backwards compatibility reasons.
Member
|
@bnoordhuis ... still need/want this? |
Member
Author
|
I'd like to see this landed, yes, or at least the first commit. |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Aug 15, 2015
Per: nodejs/node-v0.x-archive#6962 This applies only the first commit from nodejs/node-v0.x-archive#6962. /cc @bnoorduis
Member
|
Closing this here. New PR opened. We can cherry pick back to v0.12 if necessary. @bnoordhuis, just open a new PR if you want to apply the second commit too :-) |
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 23, 2015
Per: nodejs/node-v0.x-archive#6962 This applies only the first commit from nodejs/node-v0.x-archive#6962. /cc @bnoorduis Reviewed By: Ben Noordhuis <ben@strongloop.com> PR-URL: #2386
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 24, 2015
Per: nodejs/node-v0.x-archive#6962 This applies only the first commit from nodejs/node-v0.x-archive#6962. /cc @bnoorduis Reviewed By: Ben Noordhuis <ben@strongloop.com> PR-URL: #2386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the commit log:
The other commit makes the script a little more general purpose.
Suggested reviewer: @tjfontaine