This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
crypto changes to support pfx(p12) format for issue #2845 #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes for #2845 |
|
|
||
| if (pkey) { | ||
| EVP_PKEY_free(pkey); | ||
| } |
There was a problem hiding this comment.
Don't free pkey and cert here if PKCS12_parse() returned an error. That function allocates memory for the key and the certificate and updates the pointers in the argument list. On error, it frees the memory but doesn't set the pointers to NULL. You'd be double-freeing them here.
|
It's not quite there yet but it's a good start. Well done. |
|
@bnoordhuis, Please review these changes. |
| pass = new char[passlen]; | ||
| int pass_written = DecodeWrite(pass, passlen, args[1], BINARY); | ||
|
|
||
| pass[passlen] = '\0'; |
There was a problem hiding this comment.
Off-by-one error, pass[passlen] is outside the buffer.
mhdawson
added a commit
to ibmruntimes/node
that referenced
this pull request
Oct 21, 2015
test-child-process-fork-regr-nodejsgh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node#3459
mhdawson
added a commit
to ibmruntimes/node
that referenced
this pull request
Nov 5, 2015
test-child-process-fork-regr-nodejsgh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node#3459
mhdawson
added a commit
to ibmruntimes/node
that referenced
this pull request
Nov 5, 2015
test-child-process-fork-regr-nodejsgh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node#3459
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Jan 13, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: nodejs/node#4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 15, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: nodejs/node#4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 17, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: nodejs/node#4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
The test would sometimes time out on some platforms. Take the initial version of the test and instead of sending 100 handles, just send 2. It still fails when run with the code before the change was introduced and passes afterwards. Remove test from parallel.status. PR-URL: nodejs/node#5121 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs/node#5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
The test would sometimes time out on some platforms. Take the initial version of the test and instead of sending 100 handles, just send 2. It still fails when run with the code before the change was introduced and passes afterwards. Remove test from parallel.status. PR-URL: nodejs/node#5121 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs/node#5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
The test would sometimes time out on some platforms. Take the initial version of the test and instead of sending 100 handles, just send 2. It still fails when run with the code before the change was introduced and passes afterwards. Remove test from parallel.status. PR-URL: nodejs/node#5121 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs/node#5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Mar 4, 2016
The test is still failing sometimes because when trying to establish the second connection, the server is already closed. Bring back the code that handled this case and was removed in the last refactoring of the test. Also ignore the errors that might happen when sending the second handle to the worker because it may already have exited. PR-URL: nodejs/node#5422 Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Mar 9, 2016
The test would sometimes time out on some platforms. Take the initial version of the test and instead of sending 100 handles, just send 2. It still fails when run with the code before the change was introduced and passes afterwards. Remove test from parallel.status. PR-URL: nodejs/node#5121 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Mar 9, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs/node#5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: nodejs/node#3635
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Mar 23, 2016
The test is still failing sometimes because when trying to establish the second connection, the server is already closed. Bring back the code that handled this case and was removed in the last refactoring of the test. Also ignore the errors that might happen when sending the second handle to the worker because it may already have exited. PR-URL: nodejs/node#5422 Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Oct 12, 2016
It's not guaranteed that the first socket that tries to connect is the first that succeeds so the rest of assumptions made in the test are not correct. Fix it by making sure the second socket does not try to connect until the first has succeeded. The IPC channel can already be closed when sending the second socket. It should be allowed. Also, don't start sending messages until the worker is online. Fixes: nodejs/node#8950 PR-URL: nodejs/node#8954 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
kaiquewdev
pushed a commit
to kaiquewdev/node
that referenced
this pull request
Nov 26, 2016
It's not guaranteed that the first socket that tries to connect is the first that succeeds so the rest of assumptions made in the test are not correct. Fix it by making sure the second socket does not try to connect until the first has succeeded. The IPC channel can already be closed when sending the second socket. It should be allowed. Also, don't start sending messages until the worker is online. Fixes: nodejs/node#8950 PR-URL: nodejs/node#8954 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 7, 2016
It's not guaranteed that the first socket that tries to connect is the first that succeeds so the rest of assumptions made in the test are not correct. Fix it by making sure the second socket does not try to connect until the first has succeeded. The IPC channel can already be closed when sending the second socket. It should be allowed. Also, don't start sending messages until the worker is online. Fixes: nodejs/node#8950 PR-URL: nodejs/node#8954 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SecureContext::LoadPKCS12 to parse .pfx(p12) file
Exposed to sc.loadPKCS12
Changed crypto.createCredentials to support options.pfx