This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Add hostname to Machine line on AIX#141
Merged
richardlau merged 1 commit intonodejs:masterfrom Jan 13, 2020
Merged
Conversation
On AIX the `nodename` returned by `uname` is not always consistent with the hostname returned by `gethostname()`. Explicitly add the hostname to the `Machine:` line in the report on AIX as we already do for z/OS.
Member
Author
|
This change is required to allow cc @nodejs/platform-aix Failing CI run on Node.js 10 with current CI runs for this PR: |
sam-github
approved these changes
Jan 11, 2020
BethGriggs
approved these changes
Jan 11, 2020
richardlau
added a commit
that referenced
this pull request
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On AIX the
nodenamereturned byunameis not always consistentwith the hostname returned by
gethostname(). Explicitly add thehostname to the
Machine:line in the report on AIX as we alreadydo for z/OS.