This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Conversation
Update `tap` dependency to fix `npm audit` warning for `handlebars`. Stay on `tap` version 12 to maintain Node.js 6 compatibility. Disable "esm" to allow tests to pass on current Node.js master/13 nightlies.
Member
Author
|
This still has test issues when run with |
Member
Author
|
CI: |
Member
Author
|
and Node.js 6 (to check compatibility): https://ci.nodejs.org/job/nodereport-continuous-integration-latest/40/ (✔️) |
richardlau
added a commit
to richardlau/nodereport
that referenced
this pull request
Jul 10, 2019
* Fix npm audit warning (nodejs#136) (Richard Lau) * Update supported Node.js versions in README.md (nodejs#134) (Richard Lau)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
tapdependency to fixnpm auditwarning forhandlebars.Stay on
tapversion 12 to maintain Node.js 6 compatibility.Disable "esm" to allow tests to pass on current Node.js master/13
nightlies.
Alternative to #135 that keeps
tapat version 12 to maintaincompatibility with Node.js 6.