Get Node.js version from process.versions

If process.version is not available obtain the Node.js version
from process.versions if available.

Author: richardlau

src/node_report.cc

@@ -37,6 +37,10 @@
 #define NODEREPORT_VERSION "dev"
 #endif
 
+#if !defined(UNKNOWN_NODEVERSION_STRING)
+#define UNKNOWN_NODEVERSION_STRING "Unable to determine Node.js version\n"
+#endif
+
 #ifndef _WIN32
 extern char** environ;
 #endif
@@ -72,7 +76,7 @@ const char* v8_states[] = {"JS", "GC", "COMPILER", "OTHER", "EXTERNAL", "IDLE"};
 static bool report_active = false; // recursion protection
 static char report_filename[NR_MAXNAME + 1] = "";
 static char report_directory[NR_MAXPATH + 1] = ""; // defaults to current working directory
-static std::string version_string = "Unable to determine Node.js version\n";
+static std::string version_string = UNKNOWN_NODEVERSION_STRING;
 #ifdef _WIN32
 static SYSTEMTIME loadtime_tm_struct; // module load time
 #else  // UNIX, OSX
@@ -195,6 +199,7 @@ unsigned int ProcessNodeReportVerboseSwitch(const char* args) {
 void SetVersionString(Isolate* isolate) {
   // Catch anything thrown and gracefully return
   Nan::TryCatch trycatch;
+  version_string = UNKNOWN_NODEVERSION_STRING;
 
   // Retrieve the process object
   v8::Local<v8::String> process_prop;
@@ -209,20 +214,21 @@ void SetVersionString(Isolate* isolate) {
   if (!Nan::New<v8::String>("version").ToLocal(&version_prop)) return;
   v8::Local<v8::Value> version;
   if (!Nan::Get(process_obj, version_prop).ToLocal(&version)) return;
-  if (!version->IsString()) return;
 
-  // Format Node.js version for output in report
   // e.g. Node.js version: v6.9.1
-  Nan::Utf8String node_version(version);
-  version_string.assign("Node.js version: ");
-  version_string.append(*node_version);
-  version_string.append("\n");
+  if (version->IsString()) {
+    Nan::Utf8String node_version(version);
+    version_string = "Node.js version: ";
+    version_string += *node_version;
+    version_string += "\n";
+  }
 
   // Get process.versions
   v8::Local<v8::String> versions_prop;
   if (!Nan::New<v8::String>("versions").ToLocal(&versions_prop)) return;
   v8::Local<v8::Value> versions_value;
   if (!Nan::Get(process_obj, versions_prop).ToLocal(&versions_value)) return;
+  if (!versions_value->IsObject()) return;
   v8::Local<v8::Object> versions_obj = versions_value.As<v8::Object>();
 
   // Get component names and versions from process.versions
@@ -239,14 +245,21 @@ void SetVersionString(Isolate* isolate) {
     if (!Nan::Get(versions_obj, name_value).ToLocal(&version_value)) continue;
 
     Nan::Utf8String component_name(name_value);
-    // Don't duplicate the Node.js version
-    if (!strcmp("node", *component_name)) continue;
-
     Nan::Utf8String component_version(version_value);
-    std::string component_version_string(*component_name);
-    component_version_string.append(": ");
-    component_version_string.append(*component_version);
-    comp_versions.push_back(component_version_string);
+
+    // Don't duplicate the Node.js version
+    if (!strcmp("node", *component_name)) {
+      if (version_string == UNKNOWN_NODEVERSION_STRING) {
+        version_string = "Node.js version: v";
+        version_string += *component_version;
+        version_string += "\n";
+      }
+    } else {
+      std::string component_version_string(*component_name);
+      component_version_string += ": ";
+      component_version_string += *component_version;
+      comp_versions.push_back(component_version_string);
+    }
   }
 
   // Format sorted component versions surrounded by (), wrapped
@@ -255,22 +268,22 @@ void SetVersionString(Isolate* isolate) {
   //  openssl: 1.0.2j, uv: 1.9.1, v8: 5.1.281.84, zlib: 1.2.8)
   const size_t wrap = 80;
   size_t line_length = 1;
-  version_string.append("(");
+  version_string += "(";
   std::sort(comp_versions.begin(), comp_versions.end());
   for (auto it = comp_versions.begin(); it != comp_versions.end(); ++it) {
     size_t length = (*it).length();
     if (line_length + length + 1 >= wrap) {
-      version_string.append("\n ");
+      version_string += "\n ";
       line_length = 1;
     }
-    version_string.append(*it);
+    version_string += *it;
     line_length += length;
     if (it + 1 != comp_versions.end()) {
-      version_string.append(", ");
+      version_string += ", ";
       line_length += 2;
     }
   }
-  version_string.append(")\n");
+  version_string += ")\n";
 }
 
 /*******************************************************************************

test/test-api-bad-processversion.js

@@ -18,8 +18,7 @@ if (process.argv[2] === 'child') {
     const reports = common.findReports(child.pid);
     tap.equal(reports.length, 1, 'Found reports ' + reports);
     const report = reports[0];
-    const validateOpts = { pid: child.pid, expectNodeVersion: false,
-      expectedVersions: [] };
+    const validateOpts = { pid: child.pid, expectNodeVersion: true };
     common.validate(tap, report, validateOpts);
   });
 }

test/test-api-noversioninfo.js

@@ -0,0 +1,28 @@
+'use strict';
+
+// Testcase to check NodeReport succeeds if both process.version and
+// process.versions are damaged
+if (process.argv[2] === 'child') {
+  // Tamper with the process object
+  delete process['version'];
+  delete process['versions'];
+
+  const nodereport = require('../');
+  nodereport.triggerReport();
+} else {
+  const common = require('./common.js');
+  const spawn = require('child_process').spawn;
+  const tap = require('tap');
+
+  const child = spawn(process.execPath, [__filename, 'child']);
+  child.on('exit', (code) => {
+    tap.plan(3);
+    tap.equal(code, 0, 'Process exited cleanly');
+    const reports = common.findReports(child.pid);
+    tap.equal(reports.length, 1, 'Found reports ' + reports);
+    const report = reports[0];
+    const validateOpts = { pid: child.pid, expectNodeVersion: false,
+      expectedVersions: [] };
+    common.validate(tap, report, validateOpts);
+  });
+}