Update test suite to pass on latest nightly #36
Conversation
package.json
Outdated
| "scripts": { | ||
| "pretest": "eslint --rulesdir=tools/eslint-rules lib test", | ||
| "test": "tap \"test/**/*.test.js\"", | ||
| "test": "tap \"test/cli/*.test.js\"", |
There was a problem hiding this comment.
This glob is interpreted differently, depending on who is running our test suite. This means that if we ever add tests outside of test/cli we'll have to change this.
|
/cc @ofrobots Missed this one in the initial PR (because of the broken glob). |
hybrist
force-pushed
the
jk-embedded-failures
branch
from
ef6a485 to
41148d7
Compare
|
Woah, guess a lot changed in master recently. |
hybrist
changed the title
|
The new |
|
Passing CI against latest nightly: https://ci.nodejs.org/job/node-inspect-continuous-integration/28/ |
| "scripts": { | ||
| "pretest": "eslint --rulesdir=tools/eslint-rules lib test", | ||
| "test": "tap \"test/**/*.test.js\"", | ||
| "test": "tap test", |
There was a problem hiding this comment.
Is it ok that this might load non-test js files? (ones intended to be require()ed from elsewhere?)
There was a problem hiding this comment.
Right now there's only one of those (test/cli/start-cli.js) which is a bit annoying. In future, I'd rather move those helpers into a sibling directory (test-helpers/) than risk the inconsistent glob behavior.
The port export no longer exists and isn't in use. It was a hold-over from the old built-in debugger.