Skip to content

feat: promisify clean #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: promisify clean #2357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bd89ed
feat: promisify clean
imatlopez Mar 31, 2021
9d3d7d9
fix: no response expected
imatlopez Apr 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/clean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,18 @@

const rm = require('rimraf')
const log = require('npmlog')
const util = require('util')

function clean (gyp, argv, callback) {
async function clean (gyp, argv) {
// Remove the 'build' dir
var buildDir = 'build'
const buildDir = 'build'

log.verbose('clean', 'removing "%s" directory', buildDir)
rm(buildDir, callback)
return util.promisify(rm)(buildDir)
}

module.exports = clean
module.exports = function (gyp, argv, callback) {
// no response expected
clean(gyp, argv).then(() => callback(), callback)
}
module.exports.usage = 'Removes any generated build files and the "out" dir'