Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iteritems() -> items() in compile_commands_json.py #1947

Closed
wants to merge 4 commits into from
Closed

iteritems() -> items() in compile_commands_json.py #1947

wants to merge 4 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 27, 2019 •
edited
Loading

Fixes: #1946

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

richardlau and others added 4 commits October 24, 2019 14:54
@richardlau @rvagg
src,win: allow 403 errors for arm64 node.lib
e6aca7d 
The servers hosting the header packages for Electron return 403
instead of 404 for the constructed URL for arm64 node.lib for
older releases that do not support arm64.

PR-URL: nodejs#1934
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
@cclauss @gengjiawen
Finish decode stdout on Python 3 (nodejs#1937)
a48f09b
@cclauss @gengjiawen
Fix TypeError in XcodeVersion() (nodejs#1939)
ec4d403 
* Fix TypeError in XcodeVersion()

* fixup: Consistantly use tuple unpacking

* fixup: Consistantly use tuple unpacking
@cclauss
iteritems() -> items() in compile_commands_json.py
77a3384
@cclauss cclauss added the Python label Oct 27, 2019
@gengjiawen
Copy link
Member

Can you rebase this ? Thanks. @cclauss

@gengjiawen gengjiawen mentioned this pull request Oct 29, 2019
Closed
63 tasks
rvagg pushed a commit that referenced this pull request Oct 30, 2019
@cclauss @rvagg
gyp: iteritems() -> items() in compile_commands_json.py
c0282da 
PR-URL: #1947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg
Copy link
Member

rvagg commented Oct 30, 2019

picked off the HEAD commit and landed as c0282da
@cclauss I think you've been preparing separate pull requests off the same branch, or inheriting previous branches for newer PRs rather than master.

@rvagg rvagg closed this Oct 30, 2019
@rvagg rvagg mentioned this pull request Oct 31, 2019
Closed
@bnoordhuis bnoordhuis mentioned this pull request Nov 3, 2019
Closed
rvagg pushed a commit that referenced this pull request Nov 18, 2019
@cclauss @rvagg
gyp: iteritems() -> items() in compile_commands_json.py
c722971 
PR-URL: #1947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg rvagg mentioned this pull request Nov 18, 2019
Closed
@timbru31 timbru31 mentioned this pull request Nov 20, 2019
Closed
@cclauss cclauss deleted the fix-iteritems-in-compile_commands_json.py branch June 23, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@sam-github sam-github Awaiting requested review from sam-github

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compile_commands_json breaks on Python3
4 participants
@cclauss @gengjiawen @rvagg @richardlau