Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running Windows on Travis CI #1812

Closed

Conversation

joaocgreis
Copy link
Member

Checklist
Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

test-addon.js includes compiling code, making the default 30 second
timeout not suitable. This increases the timeout for all platforms,
which is a potential problem everywhere, fixing the timeout that
happens on Windows.

Fixes: nodejs#1801
Test the oldest supported Node version on Windows.
@joaocgreis
Copy link
Member Author

@rvagg
Copy link
Member

rvagg commented Jul 9, 2019

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

@cclauss
Copy link
Contributor

cclauss commented Jul 9, 2019

travis_wait might be worth considering. But perhaps not.

joaocgreis added a commit that referenced this pull request Jul 9, 2019
test-addon.js includes compiling code, making the default 30 second
timeout not suitable. This increases the timeout for all platforms,
which is a potential problem everywhere, fixing the timeout that
happens on Windows.

Fixes: #1801
PR-URL: #1812
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
joaocgreis added a commit that referenced this pull request Jul 9, 2019
Test the oldest supported Node version on Windows.

PR-URL: #1812
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@joaocgreis
Copy link
Member Author

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.

@joaocgreis joaocgreis closed this Jul 9, 2019
@rvagg rvagg mentioned this pull request Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis CI tests are failing on Windows
5 participants