Closed
Conversation
jkunkee
force-pushed
the
add-arm64-asm
branch
from
29998a3 to
96472fa
Compare
Contributor
Author
|
This is a much smaller change than #1678, but they may overlap some. |
3 tasks
Contributor
Author
|
This PR is redundant with upgrading node-gyp's GYP to refack/GYP. |
This change allows MSVS projects generated for ARM64 to include ASM files.
Contributor
Author
|
#1678's GYP-specific parts were separated into refack/GYP3#33, then that was ported back as #1739. It might have a merge conflict with this PR, but they do not functionally overlap. |
joaocgreis
pushed a commit
to JaneaSystems/node-gyp
that referenced
this pull request
May 7, 2019
This change allows MSVS projects generated for ARM64 to include ASM files. PR-URL: nodejs#1679 Reviewed-By: João Reis <reis@janeasystems.com>
joaocgreis
approved these changes
May 7, 2019
Member
|
CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/126/ ✔️ Landed in 721eb69 Thanks! |
Closed
This was referenced Oct 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
This is a port of nodejs/node#26020 (see also refack/GYP3#23) to the
node-gypcopy of GYP. It is important when building Node.js itself (V8 has ASM bits; hence the other PR) and when building native modules with ASM (fairly rare, as I understand it).