win: use msbuild from the configure stage#1654
Merged
refack merged 1 commit intonodejs:masterfrom Feb 13, 2019
Merged
Conversation
If node-gyp configure has set up MSBuild location use it instead the one that happens to be first on the PATH. Fixes: nodejs#1653
richardlau
approved these changes
Jan 22, 2019
refack
approved these changes
Jan 22, 2019
Contributor
|
@bzoz thanks for the fix. Could you add a test? (maybe run |
joaocgreis
approved these changes
Feb 13, 2019
Member
|
CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/115/ ✔️ @refack do you mind if I land this even without the test? Change here is pretty straightforward and there was no test before. |
Contributor
|
@joaocgreis, done. |
refack
pushed a commit
to refack/node-gyp
that referenced
this pull request
Feb 13, 2019
If node-gyp configure has set up MSBuild location use it instead the one that happens to be first on the PATH. PR-URL: nodejs#1654 Fixes: nodejs#1653 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
If node-gyp configure has set up MSBuild location use it instead the one that happens to be first on the PATH.
Fixes: #1653