Closed
Conversation
Suggest using --verbose npm switch when providing logs. Hopefully, better direct users to use backticks correctly.
richardlau
approved these changes
Nov 28, 2018
joaocgreis
approved these changes
Nov 28, 2018
.github/ISSUE_TEMPLATE.md
Outdated
| Paste your log here, between the backticks. It can be: | ||
| - npm --verbose output, | ||
| - or contents of npm-debug.log, | ||
| - or verbose build output. |
Member
There was a problem hiding this comment.
Suggested change
| - or verbose build output. | |
| - output of `node-gyp rebuild --verbose` |
bnoordhuis
approved these changes
Dec 11, 2018
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM if you include João's suggestion.
Contributor
Author
|
I don't have write access here, can someone land this please? |
joaocgreis
pushed a commit
that referenced
this pull request
Dec 19, 2018
Suggest using --verbose npm switch when providing logs. Hopefully, better direct users to use backticks correctly. PR-URL: #1618 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
|
CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/113/ ✔️ Landed in 53b6074 |
rvagg
pushed a commit
that referenced
this pull request
Apr 24, 2019
Suggest using --verbose npm switch when providing logs. Hopefully, better direct users to use backticks correctly. PR-URL: #1618 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Improve the issue template:
--verbosenpm switch when providing logs