Open the build file with universal-newlines mode #1053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure platform specific newlines ('\r\n' or '\r') are converted to '\n' which otherwise will fail eval().
This should handle multiple issues reported on syntax error reading binding.gyp (partial list):
nodejs#979
nodejs#199
nospaceships/node-net-ping#24
nospaceships/node-net-ping#21
mathiask88/node-snap7#11
node-hid/node-hid#28
xdenser/node-firebird-libfbclient#24
|
Hi @bnoordhuis |
|
CI looks happy. Your author name is "Guy", is that how you want to show up in the release notes? |
|
Oh didn't notice, fixed my profile to my full name. Thanks |
bnoordhuis
pushed a commit
that referenced
this pull request
Nov 16, 2016
To make sure platform specific newlines ('\r\n' or '\r') are converted
to '\n' which otherwise will fail eval().
This should handle multiple issues reported on syntax error reading
binding.gyp (partial list):
#979
#199
nospaceships/node-net-ping#24
nospaceships/node-net-ping#21
mathiask88/node-snap7#11
node-hid/node-hid#28
xdenser/node-firebird-libfbclient#24
PR-URL: #1053
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks, landed in 05c4494. |
refack
pushed a commit
to refack/node-gyp
that referenced
this pull request
Apr 23, 2017
To make sure platform specific newlines ('\r\n' or '\r') are converted
to '\n' which otherwise will fail eval().
This should handle multiple issues reported on syntax error reading
binding.gyp (partial list):
nodejs#979
nodejs#199
nospaceships/node-net-ping#24
nospaceships/node-net-ping#21
mathiask88/node-snap7#11
node-hid/node-hid#28
xdenser/node-firebird-libfbclient#24
PR-URL: nodejs#1053
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack
pushed a commit
to refack/node-gyp
that referenced
this pull request
Aug 19, 2017
To make sure platform specific newlines ('\r\n' or '\r') are converted
to '\n' which otherwise will fail eval().
This should handle multiple issues reported on syntax error reading
binding.gyp (partial list):
nodejs#979
nodejs#199
nospaceships/node-net-ping#24
nospaceships/node-net-ping#21
mathiask88/node-snap7#11
node-hid/node-hid#28
xdenser/node-firebird-libfbclient#24
PR-URL: nodejs#1053
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure platform specific newlines ('\r\n' or '\r') are converted to '\n' which otherwise will fail eval().
Reference to python docs (Note: this mode is deprecated in python3 but needed in python2)
https://docs.python.org/2.7/glossary.html#term-universal-newlines
https://docs.python.org/2.7/library/functions.html#open
This should handle multiple issues reported on syntax error reading binding.gyp (partial list):
#979
#199
nospaceships/node-net-ping#24
nospaceships/node-net-ping#21
mathiask88/node-snap7#11
node-hid/node-hid#28
xdenser/node-firebird-libfbclient#24