Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bb92c76
Choose a base ref
...
head repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 66ad305
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 11, 2019

  1. python: move Python detection to its own file 

    PR-URL: #1815
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @joaocgreis
    joaocgreis committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    7e7fce3 View commit details
    Browse the repository at this point in the history

  2. python: accept Python 3 conditionally 

    This allows us to start testing Python 3 without breaking node-gyp
for users.

This also adds support for NODE_GYP_FORCE_PYTHON, which will be the
only Python binary acceptable when defined.

PR-URL: #1815
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @joaocgreis
    joaocgreis committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    66ad305 View commit details
    Browse the repository at this point in the history
Loading