Skip to content

Commit d3583d7

Browse files
committed
Merge pull request #511 from kui/fix-zero-env-jobs
Fix for 'make' failure when process.env.JOBS is '0'
2 parents b4c3d88 + 44cf853 commit d3583d7

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

lib/build.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,9 @@ function build (gyp, argv, callback) {
222222
var p = arch === 'x64' ? 'x64' : 'Win32'
223223
argv.push('/p:Configuration=' + buildType + ';Platform=' + p)
224224
if (jobs) {
225-
if (!isNaN(parseInt(jobs, 10))) {
226-
argv.push('/m:' + parseInt(jobs, 10))
225+
var j = parseInt(jobs, 10)
226+
if (!isNaN(j) && j > 0) {
227+
argv.push('/m:' + j)
227228
} else if (jobs.toUpperCase() === 'MAX') {
228229
argv.push('/m:' + require('os').cpus().length)
229230
}
@@ -234,9 +235,10 @@ function build (gyp, argv, callback) {
234235
argv.push('-C')
235236
argv.push('build')
236237
if (jobs) {
237-
if (!isNaN(parseInt(jobs, 10))) {
238+
var j = parseInt(jobs, 10)
239+
if (!isNaN(j) && j > 0) {
238240
argv.push('--jobs')
239-
argv.push(parseInt(jobs, 10))
241+
argv.push(j)
240242
} else if (jobs.toUpperCase() === 'MAX') {
241243
argv.push('--jobs')
242244
argv.push(require('os').cpus().length)

0 commit comments

Comments
 (0)