Skip to content

Commit bde0a30

Browse files
committed
Fix typo in gyp patch
1 parent d702483 commit bde0a30

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

0004-Add-support-for-VS2017-to-GYP.patch

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ index edaf6ee..e34ebc5 100644
1919
if target_arch == 'x86':
2020
+ if self.short_name == '2017':
2121
+ return [os.path.normpath(
22-
+ ps.path.join(self.path, 'Common7/Tools/VsDevCmd.bat')), '/no_logo',
22+
+ os.path.join(self.path, 'Common7/Tools/VsDevCmd.bat')), '/no_logo',
2323
+ '/arch=x86']
2424
if self.short_name >= '2013' and self.short_name[-1] != 'e' and (
2525
os.environ.get('PROCESSOR_ARCHITECTURE') == 'AMD64' or
@@ -30,7 +30,7 @@ index edaf6ee..e34ebc5 100644
3030
assert target_arch == 'x64'
3131
+ if self.short_name == '2017':
3232
+ return [os.path.normpath(
33-
+ ps.path.join(self.path, 'Common7/Tools/VsDevCmd.bat')), '/no_logo',
33+
+ os.path.join(self.path, 'Common7/Tools/VsDevCmd.bat')), '/no_logo',
3434
+ '/arch=x64']
3535
arg = 'x86_amd64'
3636
# Use the 64-on-64 compiler if we're not using an express
@@ -68,7 +68,7 @@ index edaf6ee..e34ebc5 100644
6868
versions = []
6969
for version in versions_to_check:
7070
@@ -395,13 +414,18 @@ def _DetectVisualStudioVersions(versions_to_check, force_express):
71-
71+
7272
# The old method above does not work when only SDK is installed.
7373
keys = [r'HKLM\Software\Microsoft\VisualStudio\SxS\VC7',
7474
- r'HKLM\Software\Wow6432Node\Microsoft\VisualStudio\SxS\VC7']
@@ -87,7 +87,7 @@ index edaf6ee..e34ebc5 100644
8787
+ elif version != '14.0': # There is no Express edition for 2015.
8888
versions.append(_CreateVersion(version_to_year[version] + 'e',
8989
os.path.join(path, '..'), sdk_based=True))
90-
90+
9191
@@ -420,7 +444,7 @@ def SelectVisualStudioVersion(version='auto', allow_fallback=True):
9292
if version == 'auto':
9393
version = os.environ.get('GYP_MSVS_VERSION', 'auto')
@@ -111,8 +111,8 @@ index 25eb58e..d6a8ec7 100644
111111
+++ b/gyp/pylib/gyp/generator/msvs.py
112112
@@ -2664,7 +2664,7 @@ def _GetMSBuildProjectConfigurations(configurations):
113113
return [group]
114-
115-
114+
115+
116116
-def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
117117
+def _GetMSBuildGlobalProperties(spec, version, guid, gyp_file_name):
118118
namespace = os.path.splitext(gyp_file_name)[0]
@@ -127,19 +127,19 @@ index 25eb58e..d6a8ec7 100644
127127
+ vs2017_sdk = os.environ.get('vs2017_sdk', vs2017_sdk)
128128
+ if vs2017_sdk:
129129
+ msvs_windows_sdk_version = vs2017_sdk
130-
130+
131131
if platform_name == 'ARM':
132132
properties[0].append(['WindowsSDKDesktopARMSupport', 'true'])
133133
@@ -3366,7 +3371,8 @@ def _GenerateMSBuildProject(project, options, version, generator_flags):
134134
}]
135-
135+
136136
content += _GetMSBuildProjectConfigurations(configurations)
137137
- content += _GetMSBuildGlobalProperties(spec, project.guid, project_file_name)
138138
+ content += _GetMSBuildGlobalProperties(spec, version, project.guid,
139139
+ project_file_name)
140140
content += import_default_section
141141
content += _GetMSBuildConfigurationDetails(spec, project.build_file)
142142
if spec.get('msvs_enable_winphone'):
143-
--
143+
--
144144
2.11.0.windows.1
145145

gyp/pylib/gyp/MSVSVersion.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def _SetupScriptInternal(self, target_arch):
8888
if target_arch == 'x86':
8989
if self.short_name == '2017':
9090
return [os.path.normpath(
91-
ps.path.join(self.path, 'Common7/Tools/VsDevCmd.bat')), '/no_logo',
91+
os.path.join(self.path, 'Common7/Tools/VsDevCmd.bat')), '/no_logo',
9292
'/arch=x86']
9393
if self.short_name >= '2013' and self.short_name[-1] != 'e' and (
9494
os.environ.get('PROCESSOR_ARCHITECTURE') == 'AMD64' or
@@ -104,7 +104,7 @@ def _SetupScriptInternal(self, target_arch):
104104
assert target_arch == 'x64'
105105
if self.short_name == '2017':
106106
return [os.path.normpath(
107-
ps.path.join(self.path, 'Common7/Tools/VsDevCmd.bat')), '/no_logo',
107+
os.path.join(self.path, 'Common7/Tools/VsDevCmd.bat')), '/no_logo',
108108
'/arch=x64']
109109
arg = 'x86_amd64'
110110
# Use the 64-on-64 compiler if we're not using an express

0 commit comments

Comments
 (0)