Skip to content

Commit abef93d

Browse files
cclaussrvagg
authored andcommitted
gyp: get ready for python 3
#1335 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 788e767 commit abef93d

26 files changed

+198
-178
lines changed

gyp/pylib/gyp/MSVSSettings.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
The MSBuild schemas were also considered. They are typically found in the
1414
MSBuild install directory, e.g. c:\Program Files (x86)\MSBuild
1515
"""
16+
from __future__ import print_function
1617

1718
import sys
1819
import re
@@ -400,7 +401,7 @@ def _ValidateExclusionSetting(setting, settings, error_msg, stderr=sys.stderr):
400401

401402
if unrecognized:
402403
# We don't know this setting. Give a warning.
403-
print >> stderr, error_msg
404+
print(error_msg, file=stderr)
404405

405406

406407
def FixVCMacroSlashes(s):
@@ -461,9 +462,9 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
461462
# Invoke the translation function.
462463
try:
463464
msvs_tool[msvs_setting](msvs_value, msbuild_settings)
464-
except ValueError, e:
465-
print >> stderr, ('Warning: while converting %s/%s to MSBuild, '
466-
'%s' % (msvs_tool_name, msvs_setting, e))
465+
except ValueError as e:
466+
print(('Warning: while converting %s/%s to MSBuild, '
467+
'%s' % (msvs_tool_name, msvs_setting, e)), file=stderr)
467468
else:
468469
_ValidateExclusionSetting(msvs_setting,
469470
msvs_tool,
@@ -472,8 +473,8 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
472473
(msvs_tool_name, msvs_setting)),
473474
stderr)
474475
else:
475-
print >> stderr, ('Warning: unrecognized tool %s while converting to '
476-
'MSBuild.' % msvs_tool_name)
476+
print(('Warning: unrecognized tool %s while converting to '
477+
'MSBuild.' % msvs_tool_name), file=stderr)
477478
return msbuild_settings
478479

479480

@@ -517,9 +518,9 @@ def _ValidateSettings(validators, settings, stderr):
517518
if setting in tool_validators:
518519
try:
519520
tool_validators[setting](value)
520-
except ValueError, e:
521-
print >> stderr, ('Warning: for %s/%s, %s' %
522-
(tool_name, setting, e))
521+
except ValueError as e:
522+
print(('Warning: for %s/%s, %s' %
523+
(tool_name, setting, e)), file=stderr)
523524
else:
524525
_ValidateExclusionSetting(setting,
525526
tool_validators,
@@ -528,7 +529,7 @@ def _ValidateSettings(validators, settings, stderr):
528529
stderr)
529530

530531
else:
531-
print >> stderr, ('Warning: unrecognized tool %s' % tool_name)
532+
print(('Warning: unrecognized tool %s' % tool_name), file=stderr)
532533

533534

534535
# MSVS and MBuild names of the tools.

gyp/pylib/gyp/MSVSVersion.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def _RegistryQuery(key, value=None):
158158
text = None
159159
try:
160160
text = _RegistryQueryBase('Sysnative', key, value)
161-
except OSError, e:
161+
except OSError as e:
162162
if e.errno == errno.ENOENT:
163163
text = _RegistryQueryBase('System32', key, value)
164164
else:

gyp/pylib/gyp/__init__.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# Use of this source code is governed by a BSD-style license that can be
55
# found in the LICENSE file.
66

7+
from __future__ import print_function
78
import copy
89
import gyp.input
910
import optparse
@@ -34,8 +35,8 @@ def DebugOutput(mode, message, *args):
3435
pass
3536
if args:
3637
message %= args
37-
print '%s:%s:%d:%s %s' % (mode.upper(), os.path.basename(ctx[0]),
38-
ctx[1], ctx[2], message)
38+
print('%s:%s:%d:%s %s' % (mode.upper(), os.path.basename(ctx[0]),
39+
ctx[1], ctx[2], message))
3940

4041
def FindBuildFiles():
4142
extension = '.gyp'
@@ -226,12 +227,12 @@ def Noop(value):
226227
(action == 'store_false' and not value)):
227228
flags.append(opt)
228229
elif options.use_environment and env_name:
229-
print >>sys.stderr, ('Warning: environment regeneration unimplemented '
230+
print(('Warning: environment regeneration unimplemented '
230231
'for %s flag %r env_name %r' % (action, opt,
231-
env_name))
232+
env_name)), file=sys.stderr)
232233
else:
233-
print >>sys.stderr, ('Warning: regeneration unimplemented for action %r '
234-
'flag %r' % (action, opt))
234+
print(('Warning: regeneration unimplemented for action %r '
235+
'flag %r' % (action, opt)), file=sys.stderr)
235236

236237
return flags
237238

@@ -475,7 +476,7 @@ def gyp_main(args):
475476
if home_dot_gyp != None:
476477
default_include = os.path.join(home_dot_gyp, 'include.gypi')
477478
if os.path.exists(default_include):
478-
print 'Using overrides found in ' + default_include
479+
print('Using overrides found in ' + default_include)
479480
includes.append(default_include)
480481

481482
# Command-line --include files come after the default include.
@@ -536,7 +537,7 @@ def gyp_main(args):
536537
def main(args):
537538
try:
538539
return gyp_main(args)
539-
except GypError, e:
540+
except GypError as e:
540541
sys.stderr.write("gyp: %s\n" % e)
541542
return 1
542543

gyp/pylib/gyp/common.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ def close(self):
363363
same = False
364364
try:
365365
same = filecmp.cmp(self.tmp_path, filename, False)
366-
except OSError, e:
366+
except OSError as e:
367367
if e.errno != errno.ENOENT:
368368
raise
369369

@@ -382,9 +382,9 @@ def close(self):
382382
#
383383
# No way to get the umask without setting a new one? Set a safe one
384384
# and then set it back to the old value.
385-
umask = os.umask(077)
385+
umask = os.umask(0o77)
386386
os.umask(umask)
387-
os.chmod(self.tmp_path, 0666 & ~umask)
387+
os.chmod(self.tmp_path, 0o666 & ~umask)
388388
if sys.platform == 'win32' and os.path.exists(filename):
389389
# NOTE: on windows (but not cygwin) rename will not replace an
390390
# existing file, so it must be preceded with a remove. Sadly there
@@ -464,7 +464,7 @@ def CopyTool(flavor, out_path):
464464
''.join([source[0], '# Generated by gyp. Do not edit.\n'] + source[1:]))
465465

466466
# Make file executable.
467-
os.chmod(tool_path, 0755)
467+
os.chmod(tool_path, 0o755)
468468

469469

470470
# From Alex Martelli,

gyp/pylib/gyp/easy_xml.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import re
66
import os
77
import locale
8+
from functools import reduce
89

910

1011
def XmlToString(content, encoding='utf-8', pretty=False):

gyp/pylib/gyp/flock_tool.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def ExecFlock(self, lockfile, *cmd_list):
3939
# where fcntl.flock(fd, LOCK_EX) always fails
4040
# with EBADF, that's why we use this F_SETLK
4141
# hack instead.
42-
fd = os.open(lockfile, os.O_WRONLY|os.O_NOCTTY|os.O_CREAT, 0666)
42+
fd = os.open(lockfile, os.O_WRONLY|os.O_NOCTTY|os.O_CREAT, 0o666)
4343
if sys.platform.startswith('aix'):
4444
# Python on AIX is compiled with LARGEFILE support, which changes the
4545
# struct size.

0 commit comments

Comments
 (0)