test: migrate from tape to tap

PR-URL: #1795
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

Author: rvagg

.gitignore

@@ -2,4 +2,5 @@ gyp/test
 node_modules
 test/.node-gyp
 .ncu
+.nyc_output
 package-lock.json

.travis.yml

@@ -17,7 +17,7 @@ before_script:
     - flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
     - npm install
 script:
-    - npm test
+    - npm run test
     #- pytest --capture=sys  # add other tests here
 notifications:
     on_success: change

package.json

@@ -43,10 +43,11 @@
     "eslint": "^5.0.1",
     "nan": "^2.0.0",
     "require-inject": "~1.3.0",
-    "tape": "~4.2.0"
+    "tap": "~14.2.4"
   },
   "scripts": {
     "lint": "eslint bin lib test",
-    "test": "npm run lint && tape test/test-*"
+    "test": "npm run lint && tap test/test-*",
+    "test-ci": "npm run lint && tap -Rtap test/test-*"
   }
 }

test/simple-proxy.js

@@ -13,7 +13,6 @@ function handler (req, res) {
     throw new Error('request url [' + req.url + '] does not start with [' + prefix + ']')
 
   var upstreamUrl = upstream + req.url.substring(prefix.length)
-  console.log(req.url + ' -> ' + upstreamUrl)
   https.get(upstreamUrl, function (ures) {
     ures.on('end', function () {
       if (++calls == 2)

test/test-addon.js

@@ -1,6 +1,6 @@
 'use strict'
 
-var test = require('tape')
+var test = require('tap').test
 var path = require('path')
 var fs = require('graceful-fs')
 var child_process = require('child_process')
@@ -15,7 +15,6 @@ function runHello(hostProcess) {
     hostProcess = process.execPath
   }
   var testCode = "console.log(require('hello_world').hello())"
-  console.log('running ', hostProcess);
   return execFileSync(hostProcess, ['-e', testCode], { cwd: __dirname }).toString()
 }
 
@@ -25,7 +24,6 @@ function runDuplicateBindings() {
     "console.log((function(bindings) {" +
     "return bindings.pointerCheck1(bindings.pointerCheck2());" +
     "})(require('duplicate_symbols')))"
-  console.log('running ', hostProcess);
   return execFileSync(hostProcess, ['-e', testCode], { cwd: __dirname }).toString()
 }
 

test/test-configure-python.js

@@ -1,6 +1,6 @@
 'use strict'
 
-var test = require('tape')
+var test = require('tap').test
 var path = require('path')
 var gyp = require('../lib/node-gyp')
 var requireInject = require('require-inject')
@@ -17,6 +17,8 @@ var EXPECTED_PYPATH = path.join(__dirname, '..', 'gyp', 'pylib')
 var SEPARATOR = process.platform == 'win32' ? ';' : ':'
 var SPAWN_RESULT = { on: function () { } }
 
+require('npmlog').level = 'warn'
+
 test('configure PYTHONPATH with no existing env', function (t) {
   t.plan(1)
 

test/test-download.js

@@ -1,11 +1,13 @@
 'use strict'
 
+var test = require('tap').test
 var fs = require('fs')
 var http = require('http')
 var https = require('https')
-var test = require('tape')
 var install = require('../lib/install')
 
+require('npmlog').level = 'warn'
+
 test('download over http', function (t) {
   t.plan(2)
 

test/test-find-accessible-sync.js

@@ -1,6 +1,6 @@
 'use strict'
 
-var test = require('tape')
+var test = require('tap').test
 var path = require('path')
 var requireInject = require('require-inject')
 var configure = requireInject('../lib/configure', {

test/test-find-node-directory.js

@@ -1,4 +1,4 @@
-var test = require('tape')
+var test = require('tap').test
 var path = require('path')
 var findNodeDirectory = require('../lib/find-node-directory')
 

test/test-find-python.js

@@ -1,10 +1,12 @@
 'use strict'
 
-var test = require('tape')
+var test = require('tap').test
 var configure = require('../lib/configure')
 var execFile = require('child_process').execFile
 var PythonFinder = configure.test.PythonFinder
 
+require('npmlog').level = 'warn'
+
 test('find python', function (t) {
   t.plan(4)
 

test/test-find-visualstudio.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const test = require('tape')
+var test = require('tap').test
 const fs = require('fs')
 const path = require('path')
 const findVisualStudio = require('../lib/find-visualstudio')

test/test-install.js

@@ -1,8 +1,10 @@
 'use strict'
 
-var test = require('tape')
+var test = require('tap').test
 var install = require('../lib/install').test.install
 
+require('npmlog').level = 'error' // we expect a warning
+
 test('EACCES retry once', function (t) {
   t.plan(3)
 
@@ -14,7 +16,6 @@ test('EACCES retry once', function (t) {
     t.ok(true);
   }
 
-
   var gyp = {}
   gyp.devDir = __dirname
   gyp.opts = {}

test/test-options.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var test = require('tape')
+var test = require('tap').test
 var gyp = require('../lib/node-gyp')
 
 test('options in environment', function (t) {

test/test-process-release.js

@@ -1,4 +1,4 @@
-var test = require('tape')
+var test = require('tap').test
 var processRelease = require('../lib/process-release')
 
 test('test process release - process.version = 0.8.20', function (t) {