Commit 5785bae
committed
xcode_emulation: work in the absence of xcodebuild
OS X systems running only the Command Line Tools for Xcode package,
without the full Xcode, don't have a functioning xcodebuild, but this
isn't mandatory for building many gyp projects (e.g. node.js, v8).
This commit handles xcodebuild failures and avoids populating
Xcode-specific CFLAGS/LDFLAGS when xcodebuild can't be run.
This has been tested on both Xcode and CLT-only systems by successfully
building node.js. The behaviour can be simulated on systems with Xcode
by setting the xcode-select path to something nonsensical, e.g.
xcode-select -switch /usr/bin
BUG=https://code.google.com/p/gyp/issues/detail?id=292
Review URL: https://codereview.chromium.org/102733012/
Patch from mistydemeo@gmail.com!
This was a manual cherry-pick from:
https://code.google.com/p/gyp/source/detail?r=1819
Fixes #341.1 parent 90dbe71 commit 5785bae
1 file changed
+22
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
276 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
277 | 284 | | |
278 | 285 | | |
279 | 286 | | |
| |||
397 | 404 | | |
398 | 405 | | |
399 | 406 | | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
404 | 412 | | |
405 | 413 | | |
406 | 414 | | |
| |||
647 | 655 | | |
648 | 656 | | |
649 | 657 | | |
650 | | - | |
651 | | - | |
652 | | - | |
653 | | - | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
654 | 663 | | |
655 | 664 | | |
656 | 665 | | |
| |||
826 | 835 | | |
827 | 836 | | |
828 | 837 | | |
829 | | - | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
830 | 842 | | |
831 | 843 | | |
832 | 844 | | |
| |||
0 commit comments