fix(git-node): update README parser to account the recent TSC changes#688
fix(git-node): update README parser to account the recent TSC changes#688aduh95 merged 1 commit intonodejs:mainfrom
Conversation
BREAKING CHANGE: Old README format is no longer supported
Is that going to break using node-core-utils to land PR's in LTS lines? cc @nodejs/releasers |
I was about to comment regarding that. We need to either backport the README recent updates first, or backporters would need to use the |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 83.45% 83.35% -0.10%
==========================================
Files 37 37
Lines 4158 4164 +6
==========================================
+ Hits 3470 3471 +1
- Misses 688 693 +5
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Not sure if it will help here, but here's what I did to make find-inactive-tsc.mjs backwards compatible: https://github.com/nodejs/node/blob/a4808b6c3b111608e0b9945c7f62534b285b0c96/tools/find-inactive-tsc.mjs#L56-L86 |
|
I think we should land this, the README change have landed on all supported release lines. wdyt @nodejs/node-core-utils? |
Refs: nodejs/node#47126
Refs: nodejs/TSC#1350
BREAKING CHANGE: Old README format is no longer supported