Skip to content

Conversation

@joyeecheung
Copy link
Member

@joyeecheung
Copy link
Member Author

Oh, this needs a test, coming

@codecov
Copy link

codecov bot commented Nov 23, 2017

Codecov Report

Merging #121 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   91.11%   91.32%   +0.21%     
==========================================
  Files          14       14              
  Lines         540      542       +2     
==========================================
+ Hits          492      495       +3     
+ Misses         48       47       -1
Impacted Files Coverage Δ
lib/pr_checker.js 97.59% <100%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22d056...2f5773e. Read the comment docs.

@joyeecheung
Copy link
Member Author

Also print the email and the status of the author requested by @targos

@joyeecheung
Copy link
Member Author

Appveyor and Travis are happy, merging

@joyeecheung joyeecheung merged commit edd107a into nodejs:master Nov 23, 2017
@targos
Copy link
Member

targos commented Nov 23, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants