Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semver-major PR landing with a single approval #747

Closed
RafaelGSS opened this issue Oct 20, 2023 · 2 comments
Closed

semver-major PR landing with a single approval #747

RafaelGSS opened this issue Oct 20, 2023 · 2 comments

Comments

@RafaelGSS
Copy link
Member

RafaelGSS commented Oct 20, 2023 •
edited
Loading

nodejs/node#47769 is a semver-major PR and landed with a single approval as you can see below image:

image

nodejs/node@b40f0c3 has:

Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

And looking at nodejs/node#47769 they did review and approve the PR at one point in time. But Robert was requested to review again in nodejs/node#47769 (comment) and Matteo was requested to review again in nodejs/node#47769 (comment).

I think there's a bug in git node land that consider the first approval only.
@aduh95
Copy link
Contributor

aduh95 commented Oct 20, 2023

It's a duplicate of #677, as I said in #677 (comment) I would argue this is working as expected.

@RafaelGSS
Copy link
Member Author

Closing in favor of #677.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aduh95 @RafaelGSS