-
Notifications
You must be signed in to change notification settings - Fork 118
Closed
Description
While testing #473 I experienced landing with linter (which landed recently #435) and I have a couple suggestions:
- Running the linter is surprisingly slow, which IMO makes the already heavyweight landing process even more cumbersome to do manually. Could we make the lint process opt-in, so folks can choose PRs they think will require lint before landing? We can set it on by default when landing via commit queue
- After the lint finished running and failed, it was not clear what I should do. A message explaining that the user should fix lint issues and run --continue would be useful
- The lint happens after applying the commits but before amending, which results in weird behavior (running --continue will amend and then stop, user will need to run --continue again to go to --final). I think linter should run as part of --final instead.
Metadata
Metadata
Assignees
Labels
No labels