Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow git node land with full PR urls #213

Closed
gibfahn opened this issue Mar 9, 2018 · 1 comment
Closed

Allow git node land with full PR urls #213

gibfahn opened this issue Mar 9, 2018 · 1 comment
Labels
enhancement Things that enhances functionality, provided by node-core-utils git-node

Comments

@gibfahn
Copy link
Member

gibfahn commented Mar 9, 2018 •
edited
Loading

#206 (comment)

Just to add, it looks like you can't currently do git node land https://github.com/nodejs/node/pull/19130.

@cPhost
@gibfahn gibfahn added the enhancement Things that enhances functionality, provided by node-core-utils label Mar 9, 2018
@aks-
Copy link
Member

aks- commented Mar 16, 2018

@gibfahn can you please assign it to me? I'll take a look in free time

aks- added a commit to aks-/node-core-utils that referenced this issue Mar 16, 2018
@aks-
allow git-node land to work with full PR url -- closes (nodejs#213)
eff9908
aks- added a commit to aks-/node-core-utils that referenced this issue Mar 16, 2018
@aks-
allow git-node land to work with full PR url (nodejs#213)
4d20b3e
aks- added a commit to aks-/node-core-utils that referenced this issue Mar 16, 2018
@aks-
allow git-node land to work with full PR url (nodejs#213)
18adefa
@aks- aks- mentioned this issue Mar 16, 2018
Merged
joyeecheung pushed a commit that referenced this issue Mar 23, 2018
@aks- @joyeecheung
allow git-node land to work with full PR url (#213) (#219)
598a3a2 
* allow git-node land to work with full PR url (#213)
* replace is-url module with regex validation
* land $URL: change help text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Things that enhances functionality, provided by node-core-utils git-node
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aks- @gibfahn @priyank-p