chore: update dependencies (#371)

Most semver-major bumps are for dropping Node.js 6 support.

Author: targos

bin/ncu-ci

@@ -127,9 +127,9 @@ const argv = yargs
   .argv;
 
 const commandToType = {
-  'commit': COMMIT,
-  'pr': PR,
-  'benchmark': BENCHMARK
+  commit: COMMIT,
+  pr: PR,
+  benchmark: BENCHMARK
 };
 
 class CICommand {
@@ -203,7 +203,7 @@ class CICommand {
       if (this.markdown) {
         clipboardy.writeSync(this.markdown);
         cli.separator('');
-        cli.log(`Written markdown to clipboard`);
+        cli.log('Written markdown to clipboard');
       } else {
         cli.error('No markdown generated');
       }
@@ -289,7 +289,7 @@ class JobCommand extends CICommand {
 class URLCommand extends CICommand {
   async initialize() {
     const { argv, cli, request, queue } = this;
-    let parsed = parseJobFromURL(argv.url);
+    const parsed = parseJobFromURL(argv.url);
     if (parsed) {
       queue.push({
         type: parsed.type,
@@ -357,6 +357,6 @@ async function main(command, argv) {
 }
 
 function handler(argv) {
-  const [ command ] = argv._;
+  const [command] = argv._;
   runPromise(main(command, argv));
 }

bin/ncu-team

@@ -53,12 +53,13 @@ async function main(argv) {
   });
   const request = new Request(credentials);
 
-  const [ command ] = argv._;
+  const [command] = argv._;
   switch (command) {
-    case 'list':
+    case 'list': {
       const info = new TeamInfo(cli, request, argv.org, argv.team);
       await info.listMembers();
       break;
+    }
     case 'sync':
       await TeamInfo.syncFile(cli, request, argv.file);
       break;

lib/auth.js

@@ -80,7 +80,7 @@ async function auth(
   }
 
   if (options.jenkins) {
-    let { username, jenkins_token } = getMergedConfig();
+    const { username, jenkins_token } = getMergedConfig();
     if (!username || !jenkins_token) {
       process.stdout.write(
         'Get your Jenkins API token in https://ci.nodejs.org/me/configure ' +

lib/backport_session.js

@@ -179,7 +179,7 @@ class BackportSession extends Session {
     const cherries = commits.map(i => i.sha).reverse();
     const pendingCommands = [
       `git cherry-pick ${cherries.join(' ')}`,
-      `git push -u <your-fork-remote> <your-branch-name>`
+      'git push -u <your-fork-remote> <your-branch-name>'
     ];
     const shouldPick = await cli.prompt(
       'Do you want to cherry-pick the commits?');

lib/cache.js

@@ -91,7 +91,7 @@ class Cache {
   }
 
   wrap(Class, identities) {
-    for (let method of Object.keys(identities)) {
+    for (const method of Object.keys(identities)) {
       const original = Class.prototype[method];
       const identity = identities[method];
       this.originals[method] = original;

lib/ci/ci_result_parser.js

@@ -324,7 +324,7 @@ class TestBuild extends Job {
         const builtOn = failure.builtOn ? `On ${failure.builtOn}: ` : '';
         output += `\n\n${builtOn}${failure.reason}\n`;
       } else {
-        output += `\n\n`;
+        output += '\n\n';
         const builtOn = failure.builtOn ? ` on ${failure.builtOn}:` : '';
         output += fold(`See failures${builtOn}`, failure.reason) + '\n\n';
       }
@@ -378,7 +378,7 @@ function pad(any, length) {
   return (any + '').padEnd(length);
 }
 
-const kHealthKeys = [ 'success', 'pending', 'aborted', 'failed', 'unstable' ];
+const kHealthKeys = ['success', 'pending', 'aborted', 'failed', 'unstable'];
 class Health {
   constructor(builds) {
     for (const key of kHealthKeys) {
@@ -450,7 +450,7 @@ class FailureAggregator {
       .value();
     const data = [];
     for (const item of groupedByReason) {
-      const [ reason, failures ] = item;
+      const [reason, failures] = item;
       // Uncomment this and redirect stderr away to see matched highlights
       // console.log('HIGHLIGHT', reason);
 
@@ -490,8 +490,8 @@ class FailureAggregator {
     let output = 'Failures in ';
     output += `[${jobName}/${first.jobid}](${first.link}) to `;
     output += `[${jobName}/${last.jobid}](${last.link}) `;
-    output += `that failed more than 2 PRs\n`;
-    output += `(Generated with \`ncu-ci `;
+    output += 'that failed more than 2 PRs\n';
+    output += '(Generated with `ncu-ci ';
     output += `${process.argv.slice(2).join(' ')}\`)\n\n`;
 
     output += this.health.formatAsMarkdown() + '\n';
@@ -736,7 +736,7 @@ function filterBuild(builds, type) {
 async function listBuilds(cli, request, type) {
   // assert(type === COMMIT || type === PR)
   const { jobName } = CI_TYPES.get(type);
-  const tree = `builds[url,result]`;
+  const tree = 'builds[url,result]';
   const url = `https://${CI_DOMAIN}/job/${jobName}/api/json?tree=${qs.escape(tree)}`;
 
   cli.startSpinner(`Querying ${url}`);
@@ -998,10 +998,10 @@ class BenchmarkRun extends Job {
     for (const line of results) {
       const star = line.indexOf('*');
       const name = line.slice(0, star).trim();
-      const [ file, ...config ] = name.split(' ');
+      const [file, ...config] = name.split(' ');
       const confidence = line.match(/(\*+)/)[1];
       const lastStar = line.lastIndexOf('*');
-      const [ improvement, ...accuracy ] =
+      const [improvement, ...accuracy] =
         line.slice(lastStar + 1).split(/\s*%/).map(i => i.trim() + '%');
       accuracy.pop(); // remove the last empty item
       json.push({

lib/ci/ci_type_parser.js

@@ -119,7 +119,7 @@ function parseJobFromURL(url) {
     return undefined;
   }
 
-  for (let [ type, info ] of CI_TYPES) {
+  for (const [type, info] of CI_TYPES) {
     const match = url.match(info.pattern);
     if (match) {
       return {

lib/config.js

@@ -38,13 +38,15 @@ exports.getConfigPath = function(configType, dir) {
   switch (configType) {
     case GLOBAL_CONFIG:
       return getNcurcPath();
-    case PROJECT_CONFIG:
+    case PROJECT_CONFIG: {
       const projectRcPath = path.join(dir || process.cwd(), '.ncurc');
       return projectRcPath;
-    case LOCAL_CONFIG:
+    }
+    case LOCAL_CONFIG: {
       const ncuDir = exports.getNcuDir(dir);
       const configPath = path.join(ncuDir, 'config');
       return configPath;
+    }
     default:
       throw Error('Invalid configType');
   }

lib/github/tree.js

@@ -76,7 +76,7 @@ class GitHubTree {
     }
     const base = 'https://raw.githubusercontent.com';
     const { owner, repo, lastCommit, path } = this;
-    let prefix = `${base}/${owner}/${repo}/${lastCommit}`;
+    const prefix = `${base}/${owner}/${repo}/${lastCommit}`;
     if (assetPath.startsWith('/')) {  // absolute
       return `${prefix}/${assetPath}`;
     } else {

lib/landing_session.js

@@ -119,7 +119,7 @@ class LandingSession extends Session {
     cli.log(`There are ${subjects.length} commits in the PR`);
     cli.log('Please run the following commands to complete landing\n\n' +
             `$ ${suggestion}\n` +
-            `$ git node land --continue`);
+            '$ git node land --continue');
   }
 
   async apply() {
@@ -241,11 +241,11 @@ class LandingSession extends Session {
   async continue() {
     const { cli } = this;
     if (this.readyToFinal()) {
-      cli.log(`Running \`final\`..`);
+      cli.log('Running `final`..');
       return this.final();
     }
     if (this.readyToAmend()) {
-      cli.log(`Running \`amend\`..`);
+      cli.log('Running `amend`..');
       return this.amend();
     }
     if (this.isApplying()) {
@@ -260,7 +260,7 @@ class LandingSession extends Session {
       return;
     }
     if (this.hasStarted()) {
-      cli.log(`Running \`apply\`..`);
+      cli.log('Running `apply`..');
       return this.apply();
     }
     cli.log(