test: add tests for cross-repository/cross-owner fixes (#197)

Fixes: #75

Author: ryzokuken

test/fixtures/data.js

@@ -59,6 +59,7 @@ const firstTimerPR = readJSON('first_timer_pr.json');
 const firstTimerPrivatePR = readJSON('first_timer_pr_with_private_email.json');
 const semverMajorPR = readJSON('semver_major_pr.json');
 const fixAndRefPR = readJSON('pr_with_fixes_and_refs.json');
+const fixCrossPR = readJSON('pr_with_fixes_cross.json');
 const conflictingPR = readJSON('conflicting_pr.json');
 const emptyProfilePR = readJSON('empty_profile_pr.json');
 const closedPR = readJSON('./closed_pr.json');
@@ -92,6 +93,7 @@ module.exports = {
   firstTimerPrivatePR,
   semverMajorPR,
   fixAndRefPR,
+  fixCrossPR,
   conflictingPR,
   emptyProfilePR,
   readme,

test/fixtures/pr_with_fixes_cross.json

@@ -0,0 +1,20 @@
+{
+  "createdAt": "2017-10-24T11:13:43Z",
+  "url": "https://github.com/nodejs/node/pull/16438",
+  "bodyHTML":
+    "<p>Fixes: <a href=\"https://github.com/joyeecheung/node-core-utils/issues/123\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"271243248\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/joyeecheung/node-core-utils/issues/123\">joyeecheung/node-core-utils#123</a></p>",
+  "bodyText": "Fixes: joyeecheung/node-core-utils#123",
+  "labels": {
+    "nodes": [
+      {
+        "name": "build"
+      },
+      {
+        "name": "npm"
+      },
+      {
+        "name": "python"
+      }
+    ]
+  }
+}

test/unit/metadata_gen.test.js

@@ -3,6 +3,7 @@
 const MetadataGenerator = require('../../lib/metadata_gen');
 const {
   fixAndRefPR,
+  fixCrossPR,
   allGreenReviewers
 } = require('../fixtures/data');
 
@@ -13,6 +14,7 @@ const data = {
   pr: fixAndRefPR,
   reviewers: allGreenReviewers
 };
+const crossData = Object.assign({}, data, { pr: fixCrossPR });
 
 const expected = `PR-URL: https://github.com/nodejs/node/pull/16438
 Fixes: https://github.com/nodejs/node/issues/16437
@@ -22,10 +24,23 @@ Reviewed-By: Quux User <quux@example.com>
 Reviewed-By: Baz User <baz@example.com>
 Reviewed-By: Bar User <bar@example.com>
 `;
+const crossExpected = `PR-URL: https://github.com/nodejs/node/pull/16438
+Fixes: https://github.com/joyeecheung/node-core-utils/issues/123
+Reviewed-By: Foo User <foo@example.com>
+Reviewed-By: Quux User <quux@example.com>
+Reviewed-By: Baz User <baz@example.com>
+Reviewed-By: Bar User <bar@example.com>
+`;
 
 describe('MetadataGenerator', () => {
   it('should generate metadata properly', () => {
     const results = new MetadataGenerator(data).getMetadata();
     assert.strictEqual(expected, results);
   });
+
+  it('should handle cross-owner and cross-repo fixes properly', () => {
+    const results = new MetadataGenerator(crossData).getMetadata();
+    console.log(results);
+    assert.strictEqual(crossExpected, results);
+  });
 });