This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: Improve AddLocal and Object::GetPropertyAttributes #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -568,6 +568,31 @@ | |||
| // CHAKRA-TODO: Need to add JSRT API to detect this | |||
| return false; | |||
| }; | |||
| utils.saveInHandleScope = function(array) { | |||
| for (var i = 1; i < arguments.length; i++) { | |||
| array.push(arguments[i]); | |||
There was a problem hiding this comment.
push accepts multiple args. Could avoid this loop?
There was a problem hiding this comment.
yes, I know. I was trying to avoid lengthy formals (8 in this case).
|
LGTM, one last nit comment. Thanks! |
|
|
`HandleScope` was simulated in chakrashim by saving references in `JavascriptArray` which involved calling `JsSetIndexedProperty` API. Although this API is not slow, but there is an overhead of calling JSRT APIs. It regress performance if `AddLocal` is called often. To avoid that, gathered elements in `_locals` stack and then bulk pushed them to array. * Earlier we called `JsCreateArray` with length 1 to create the above array. This creates an array of head segment size 4 (rounding) but since we are pushing `kOnStackLocals`, we would fill up the head segment and allocate newer segment. Instead if we pass length 0 to `JsCreateArray` it creates a head segment of size 16 and we don't have to initialize another segment till count reaches 16. * Also, I converted `Object::GetPropertyAttributes` to javascript function which should save 6 JSRT calls. I have also added `CHAKRA-TODO` comments for functions that should be easily converted to javascript functions. PR-URL: nodejs#101 Reviewed-By: Jianchun Xu <Jianchun.Xu@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
chakrashim
Description of change
HandleScopewas simulated in chakrashim by saving referencesin
JavascriptArraywhich involved callingJsSetIndexedPropertyAPI. Although this API is not slow, but there is an overhead of
calling JSRT APIs. It regress performance if
AddLocalis calledoften. To avoid that, converted the function in javascript which
would call
array.pushof bulk references we recorded so far.Also, I converted
Object::GetPropertyAttributesto javascriptfunction which should save 6 JSRT calls. I have also added
CHAKRA-TODOcomments for functions that should be easilyconverted to javascript functions.