From fd3229c25375e084c10ad04ac97343434f89db47 Mon Sep 17 00:00:00 2001 From: Mike Kaufman Date: Mon, 2 Apr 2018 10:03:55 -0700 Subject: [PATCH] test: disabling tests failing on node-chakracore --- lib/internal/bootstrap/node.js | 3 ++- test/parallel/test-console-table.js | 9 ++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js index b892afdfa6a..21f54c9d66d 100644 --- a/lib/internal/bootstrap/node.js +++ b/lib/internal/bootstrap/node.js @@ -35,7 +35,8 @@ // parser failure. Inject a cache entry to prevent the file from being // parsed. Return an array to mimic behavior (required by util.inspect). // - // TODO: below methods need to be implemented to return correct values! + // BUGBUG: https://github.com/nodejs/node-chakracore/issues/510 - Need to + // implement below to return correct values NativeModule._cache['internal/v8'] = { loaded: true, exports: { diff --git a/test/parallel/test-console-table.js b/test/parallel/test-console-table.js index 39e9099dd71..868175cd1c0 100644 --- a/test/parallel/test-console-table.js +++ b/test/parallel/test-console-table.js @@ -106,6 +106,9 @@ test([{ a: 1, b: 2 }, { a: 3, c: 4 }], ['a'], ` └─────────┴───┘ `); +// BUGBUG: https://github.com/nodejs/node-chakracore/issues/510 - need to +// re-enable for Chakra when previewMapIterator is implemented +if (!common.isChakraEngine) { test(new Map([[1, 1], [2, 2], [3, 3]]).entries(), ` ┌───────────────────┬─────┬────────┐ │ (iteration index) │ Key │ Values │ @@ -115,7 +118,11 @@ test(new Map([[1, 1], [2, 2], [3, 3]]).entries(), ` │ 2 │ 3 │ 3 │ └───────────────────┴─────┴────────┘ `); +} +// BUGBUG: https://github.com/nodejs/node-chakracore/issues/510 - need to +// re-enable for Chakra when previewMapIterator is implemented +if (!common.isChakraEngine) { test(new Set([1, 2, 3]).values(), ` ┌───────────────────┬────────┐ │ (iteration index) │ Values │ @@ -125,7 +132,7 @@ test(new Set([1, 2, 3]).values(), ` │ 2 │ 3 │ └───────────────────┴────────┘ `); - +} test({ a: { a: 1, b: 2, c: 3 } }, ` ┌─────────┬───┬───┬───┐