Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: disabling tests failing on node-chakracore
Browse files Browse the repository at this point in the history
  • Loading branch information
Mike Kaufman committed Apr 2, 2018
1 parent 5685d4b commit fd3229c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
3 changes: 2 additions & 1 deletion lib/internal/bootstrap/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
// parser failure. Inject a cache entry to prevent the file from being
// parsed. Return an array to mimic behavior (required by util.inspect).
//
// TODO: below methods need to be implemented to return correct values!
// BUGBUG: https://github.com/nodejs/node-chakracore/issues/510 - Need to
// implement below to return correct values
NativeModule._cache['internal/v8'] = {
loaded: true,
exports: {
Expand Down
9 changes: 8 additions & 1 deletion test/parallel/test-console-table.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ test([{ a: 1, b: 2 }, { a: 3, c: 4 }], ['a'], `
└─────────┴───┘
`);

// BUGBUG: https://github.com/nodejs/node-chakracore/issues/510 - need to
// re-enable for Chakra when previewMapIterator is implemented
if (!common.isChakraEngine) {
test(new Map([[1, 1], [2, 2], [3, 3]]).entries(), `
┌───────────────────┬─────┬────────┐
│ (iteration index) │ Key │ Values │
Expand All @@ -115,7 +118,11 @@ test(new Map([[1, 1], [2, 2], [3, 3]]).entries(), `
│ 2 │ 3 │ 3 │
└───────────────────┴─────┴────────┘
`);
}

// BUGBUG: https://github.com/nodejs/node-chakracore/issues/510 - need to
// re-enable for Chakra when previewMapIterator is implemented
if (!common.isChakraEngine) {
test(new Set([1, 2, 3]).values(), `
┌───────────────────┬────────┐
│ (iteration index) │ Values │
Expand All @@ -125,7 +132,7 @@ test(new Set([1, 2, 3]).values(), `
│ 2 │ 3 │
└───────────────────┴────────┘
`);

}

test({ a: { a: 1, b: 2, c: 3 } }, `
┌─────────┬───┬───┬───┐
Expand Down

0 comments on commit fd3229c

Please sign in to comment.