node is now using a V8 API to pass a SideEffectType to Object::SetAcc…

…essor. Updated shim to APIs to accept this param. Implementation ignores it.
nodejs · Jul 9, 2018 · f4fb937 · f4fb937
1 parent 3cb68f9
commit f4fb937
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -1513,7 +1513,8 @@ class V8_EXPORT Object : public Value {
                           AccessorNameSetterCallback setter = 0,
                           MaybeLocal<Value> data = MaybeLocal<Value>(),
                           AccessControl settings = DEFAULT,
-                          PropertyAttribute attribute = None);
+                          PropertyAttribute attribute = None,
+                          SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect);
 
   V8_DEPRECATE_SOON("Use maybe version", Local<Array> GetPropertyNames());
   V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(

diff --git a/deps/chakrashim/src/v8object.cc b/deps/chakrashim/src/v8object.cc
@@ -420,7 +420,8 @@ Maybe<bool> Object::SetAccessor(Local<Context> context,
                                 AccessorNameSetterCallback setter,
                                 MaybeLocal<Value> data,
                                 AccessControl settings,
-                                PropertyAttribute attribute) {
+                                PropertyAttribute attribute,
+                                SideEffectType getter_side_effect_type) {
   return SetAccessor(name, getter, setter, FromMaybe(data), settings, attribute,
                      Local<AccessorSignature>());
 }