From dffae3088b8d821eb164e6ee7a70f62083046b46 Mon Sep 17 00:00:00 2001 From: Jimmy Thomson Date: Fri, 17 Aug 2018 15:20:47 -0700 Subject: [PATCH] test: disabling unsupported parts of tests --- test/parallel/parallel.status | 6 ++++++ test/parallel/test-util-inspect.js | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 5db9a99936b..d1ec6d91189 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -237,6 +237,12 @@ test-heapdump-zlib : SKIP # see https://github.com/nodejs/node-chakracore/issues/536 test-env-newprotomethod-remove-unnecessary-prototypes : SKIP +# SharedArrayBuffers are returning null contents for some reason +# This leads to asserts in node +# Disabling this test until the problem is addressed +# https://github.com/nodejs/node-chakracore/issues/584 +test-buffer-sharedarraybuffer : SKIP + [$jsEngine==chakracore && $system==win32] # These tests are failing for Node-Chakracore and should eventually be fixed test-module-loading-globalpaths : SKIP diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js index 5219d5c5f8e..20091572cbc 100644 --- a/test/parallel/test-util-inspect.js +++ b/test/parallel/test-util-inspect.js @@ -1680,9 +1680,13 @@ if (!common.isChakraEngine) { assert.notStrictEqual(util.inspect(value), expected); }); +if (!common.isChakraEngine) { + eval(` assert.strictEqual(inspect(1n), '1n'); assert.strictEqual(inspect(Object(-1n)), '[BigInt: -1n]'); assert.strictEqual(inspect(Object(13n)), '[BigInt: 13n]'); + `); +} // Verify non-enumerable keys get escaped. {