chakrashim, test: add shim for v8::Isolate::EnqueueMicrotask and make…

… associated unit test pass on node-chakracore
nodejs · Nov 14, 2018 · d168295 · d168295
1 parent 2fa1792
commit d168295
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -2959,6 +2959,7 @@ class V8_EXPORT Isolate {
   void SetPromiseHook(PromiseHook hook);
   void SetPromiseRejectCallback(PromiseRejectCallback callback);
   void RunMicrotasks();
+  void EnqueueMicrotask(Local<Function> microtask);
   void EnqueueMicrotask(MicrotaskCallback microtask, void* data = nullptr);
   void SetMicrotasksPolicy(MicrotasksPolicy policy);
   void SetAutorunMicrotasks(bool autorun);

diff --git a/deps/chakrashim/src/v8isolate.cc b/deps/chakrashim/src/v8isolate.cc
@@ -171,6 +171,10 @@ void Isolate::SetJitCodeEventHandler(JitCodeEventOptions options,
   // need it because we do our own ETW tracing.
 }
 
+void Isolate::EnqueueMicrotask(Local<Function> microtask) {
+  jsrt::IsolateShim::FromIsolate(this)->QueueMicrotask(*microtask);
+}
+
 void Isolate::EnqueueMicrotask(MicrotaskCallback microtask, void* data) {
   // CHAKRA-TODO: Current microTask implementation only support queueing
   // javascript functions. Need to add support to queue native functions