Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 9f3b677

Browse files
committed
test: fix/skip tests for ChakraCore
* Fixed test-async-wrap-pop-id-during-load to run correctly * Skipped test-assert-builtins-not-read-from-filesystem since it's testing the assert message behavior we don't support anyway. PR-URL: #556 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
1 parent 1d30d49 commit 9f3b677

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

test/parallel/parallel.status

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ test-postmortem-metadata: PASS,FLAKY
2525
[$jsEngine==chakracore]
2626
# These tests are failing for Node-Chakracore and should eventually be fixed
2727
test-assert-checktag : SKIP
28+
test-assert-builtins-not-read-from-filesystem : SKIP
2829
test-async-hooks-disable-during-promise : SKIP
2930
test-async-hooks-enable-during-promise : SKIP
3031
test-async-hooks-promise : SKIP

test/parallel/test-async-wrap-pop-id-during-load.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
require('../common');
3+
const common = require('../common');
44

55
if (process.argv[2] === 'async') {
66
async function fn() {
@@ -13,9 +13,14 @@ if (process.argv[2] === 'async') {
1313
const assert = require('assert');
1414
const { spawnSync } = require('child_process');
1515

16+
const engineArgs = [];
17+
if (!common.isChakraEngine) {
18+
engineArgs.push('--stack_size=75');
19+
}
20+
1621
const ret = spawnSync(
1722
process.execPath,
18-
['--stack_size=75', __filename, 'async']
23+
[...engineArgs, __filename, 'async']
1924
);
2025
assert.strictEqual(ret.status, 0,
2126
`EXIT CODE: ${ret.status}, STDERR:\n${ret.stderr}`);

0 commit comments

Comments
 (0)