Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: fix/skip tests for ChakraCore
Browse files Browse the repository at this point in the history
* Fixed test-async-wrap-pop-id-during-load to run correctly
* Skipped test-assert-builtins-not-read-from-filesystem since it's
  testing the assert message behavior we don't support anyway.

PR-URL: #556
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
  • Loading branch information
kfarnung committed Jun 29, 2018
1 parent 1d30d49 commit 9f3b677
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ test-postmortem-metadata: PASS,FLAKY
[$jsEngine==chakracore]
# These tests are failing for Node-Chakracore and should eventually be fixed
test-assert-checktag : SKIP
test-assert-builtins-not-read-from-filesystem : SKIP
test-async-hooks-disable-during-promise : SKIP
test-async-hooks-enable-during-promise : SKIP
test-async-hooks-promise : SKIP
Expand Down
9 changes: 7 additions & 2 deletions test/parallel/test-async-wrap-pop-id-during-load.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

require('../common');
const common = require('../common');

if (process.argv[2] === 'async') {
async function fn() {
Expand All @@ -13,9 +13,14 @@ if (process.argv[2] === 'async') {
const assert = require('assert');
const { spawnSync } = require('child_process');

const engineArgs = [];
if (!common.isChakraEngine) {
engineArgs.push('--stack_size=75');
}

const ret = spawnSync(
process.execPath,
['--stack_size=75', __filename, 'async']
[...engineArgs, __filename, 'async']
);
assert.strictEqual(ret.status, 0,
`EXIT CODE: ${ret.status}, STDERR:\n${ret.stderr}`);
Expand Down

0 comments on commit 9f3b677

Please sign in to comment.