test: mark tests that fail with ChakraCore on CI

Mark as flaky tests that fail with ChakraCore on CI. Tests that are V8-specific and therefore will never run should be skipped in the beginning of the test code, not in the status files. PR-URL: #233 Reviewed-By: Sandeep Agarwal <saagarwa@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
nodejs · May 10, 2017 · 7e6de45 · 7e6de45
1 parent 32b144d
commit 7e6de45
Show file tree

Hide file tree

Showing 18 changed files with 85 additions and 147 deletions.
diff --git a/test/abort/test-abort-uncaught-exception.js b/test/abort/test-abort-uncaught-exception.js
@@ -6,8 +6,8 @@ const spawn = require('child_process').spawn;
 const node = process.execPath;
 
 if (common.isChakraEngine) {
-  console.log(`1..0 # Skipped: This test is disabled for chakra engine
-    because it depends on v8-option --abort-on-uncaught-exception`);
+  common.skip('This test is disabled for chakra engine because it depends ' +
+              'on v8-option --abort-on-uncaught-exception');
   return;
 }
 

diff --git a/test/addons/addon.status b/test/addons/addon.status
@@ -19,34 +19,4 @@ prefix addons
 [$system==aix]
 
 [$jsEngine==chakracore]
-01_callbacks/test : SKIP
-02_object_factory/test : SKIP
-03_function_factory/test : SKIP
-04_wrapping_c_objects/test : SKIP
-05_factory_of_wrapped_objects/test : SKIP
-06_passing_wrapped_objects_around/test : SKIP
-07_atexit_hooks/test : SKIP
-async-hello-world/test : SKIP
-at-exit/test : SKIP
-buffer-free-callback/test : SKIP
-heap-profiler/test : SKIP
-hello-world-function-export/test : SKIP
-hello-world/test : SKIP
-load-long-path/test : SKIP
-make-callback-recurse/test : SKIP
-make-callback/test : SKIP
-new-target/test : SKIP
-null-buffer-neuter/test : SKIP
-openssl-binding/test : SKIP
-parse-encoding/test : SKIP
-repl-domain-abort/test : SKIP
-stringbytes-external-exceed-max/test-stringbytes-external-at-max : SKIP
-stringbytes-external-exceed-max/test-stringbytes-external-exceed-max : SKIP
-stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-ascii : SKIP
-stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-base64 : SKIP
-stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary : SKIP
-stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex : SKIP
-stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-utf8 : SKIP
-stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-2 : SKIP
-symlinked-module/test : SKIP
-zlib-binding/test : SKIP
+new-target/test : PASS,FLAKY
diff --git a/test/addons/null-buffer-neuter/test.js b/test/addons/null-buffer-neuter/test.js
@@ -5,9 +5,9 @@ const common = require('../../common');
 const binding = require(`./build/${common.buildType}/binding`);
 
 if (common.isChakraEngine) {
-  console.log(`1..0 # Skipped: This test is disabled for chakra engine
-  because it depends on v8 GC behavior. Chakra GC may find reference-like
-  data on native stack and may not do the GC as expected.`);
+  common.skip('This test is disabled for chakra engine because it depends ' +
+              'on v8 GC behavior. Chakra GC may find reference-like data ' +
+              'on native stack and may not do the GC as expected.');
   return;
 }
 

diff --git a/test/inspector/inspector.status b/test/inspector/inspector.status
@@ -9,7 +9,4 @@ prefix inspector
 [$system==win32]
 
 [$jsEngine==chakracore]
-test-inspector : SKIP
-test-inspector-stops-no-file : SKIP
-test-not-blocked-on-idle : SKIP
-test-inspector-ip-detection : SKIP
+* : PASS,FLAKY
diff --git a/test/known_issues/known_issues.status b/test/known_issues/known_issues.status
@@ -21,7 +21,6 @@ test-cluster-disconnect-handles: SKIP
 [$system==aix]
 
 [$jsEngine==chakracore]
-test-vm-function-redefinition : SKIP
-test-vm-inherited_properties : SKIP
-test-vm-data-property-writable : SKIP
-test-vm-attributes-property-not-on-sandbox : SKIP
+test-vm-attributes-property-not-on-sandbox : PASS,FLAKY
+test-vm-data-property-writable : PASS,FLAKY
+test-vm-inherited_properties : PASS,FLAKY
diff --git a/test/message/message.status b/test/message/message.status
@@ -17,5 +17,5 @@ prefix message
 [$system==freebsd]
 
 [$jsEngine==chakracore]
-console_low_stack_space : SKIP
-unhandled_promise_trace_warnings : SKIP
+console_low_stack_space : PASS,FLAKY
+unhandled_promise_trace_warnings : PASS,FLAKY
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -27,68 +27,67 @@ test-fs-watch-enoent                 : FAIL, PASS
 test-fs-watch-encoding               : FAIL, PASS
 
 [$jsEngine==chakracore]
-test-async-wrap-check-providers : PASS,FLAKY
-test-async-wrap-check-providers : PASS,FLAKY
-test-buffer-fill  : PASS,FLAKY
-test-crypto-dh : SKIP
-test-cluster-inspector-debug-port : SKIP
-test-debugger-repeat-last: SKIP
-test-domain-no-error-handler-abort-on-uncaught-0 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-1 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-2 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-3 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-4 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-5 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-6 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-7 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-8 : SKIP
-test-domain-no-error-handler-abort-on-uncaught-9 : SKIP
-test-force-repl : SKIP
-test-force-repl-with-eval : SKIP
-test-fs-stat : SKIP
-test-http-same-map : SKIP
-test-intl : SKIP
-test-intl-no-icu-data : SKIP
-test-icu-transcode : SKIP
-test-memory-usage : SKIP
-test-promises-unhandled-rejections : SKIP
-test-promises-warning-on-unhandled-rejection : SKIP
-test-repl : SKIP
-test-repl-mode : SKIP
-test-repl-tab-complete : SKIP
-test-repl-timeout-throw : SKIP
-test-repl-sigint-nested-eval : SKIP
-test-stream-base-no-abort : SKIP
-test-string-decoder : SKIP
-test-timers-blocking-callback : SKIP
-test-timers-same-timeout-wrong-list-deleted : SKIP
-test-trace-event : SKIP
-test-util-inspect-proxy : SKIP
-test-util-inspect-simd : SKIP
-test-url-domain-ascii-unicode : SKIP
-test-v8-serdes : SKIP
-test-v8-serdes-sharedarraybuffer : SKIP
-test-vm-cached-data : SKIP
-test-vm-context : SKIP
-test-vm-create-and-run-in-context : SKIP
-test-vm-global-identity : SKIP
-test-vm-low-stack-space : SKIP
-test-vm-preserves-property : SKIP
-test-vm-property-not-on-sandbox : SKIP
-test-vm-proxies : SKIP
-test-vm-strict-mode : SKIP
-test-vm-timeout : SKIP
-test-whatwg-url-origin-for : SKIP
-test-assert-checktag : SKIP
-test-process-env-symbols : SKIP
-test-module-loading-globalpaths : SKIP
+test-assert-checktag : PASS,FLAKY
 test-buffer-bindingobj-no-zerofill : PASS,FLAKY
+test-buffer-sharedarraybuffer : PASS,FLAKY
+test-cluster-inspector-debug-port : PASS,FLAKY
+test-crypto-dh : PASS,FLAKY
+test-debugger-repeat-last : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-0 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-1 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-2 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-3 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-4 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-5 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-6 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-7 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-8 : PASS,FLAKY
+test-domain-no-error-handler-abort-on-uncaught-9 : PASS,FLAKY
+test-fs-stat : PASS,FLAKY
+test-http-pipeline-flood : PASS,FLAKY
+test-http-same-map : PASS,FLAKY
+test-intl : PASS,FLAKY
+test-intl-no-icu-data : PASS,FLAKY
+test-memory-usage : PASS,FLAKY
+test-process-env-symbols : PASS,FLAKY
+test-promises-unhandled-rejections : PASS,FLAKY
+test-promises-warning-on-unhandled-rejection : PASS,FLAKY
 test-regress-GH-12371 : PASS,FLAKY
+test-repl : PASS,FLAKY
+test-repl-mode : PASS,FLAKY
+test-repl-tab-complete : PASS,FLAKY
+test-string-decoder : PASS,FLAKY
+test-trace-event : PASS,FLAKY
+test-url-domain-ascii-unicode : PASS,FLAKY
 test-util : PASS,FLAKY
+test-util-format-shared-arraybuffer : PASS,FLAKY
+test-util-inspect-proxy : PASS,FLAKY
+test-v8-serdes : PASS,FLAKY
+test-v8-serdes-sharedarraybuffer : PASS,FLAKY
+test-vm-cached-data : PASS,FLAKY
+test-vm-context : PASS,FLAKY
+test-vm-create-and-run-in-context : PASS,FLAKY
+test-vm-debug-context : PASS,FLAKY
+test-vm-global-identity : PASS,FLAKY
+test-vm-low-stack-space : PASS,FLAKY
+test-vm-preserves-property : PASS,FLAKY
+test-vm-property-not-on-sandbox : PASS,FLAKY
+test-vm-strict-mode : PASS,FLAKY
+test-vm-timeout : PASS,FLAKY
 test-zlib-convenience-methods : PASS,FLAKY
-test-http-pipeline-flood : PASS,FLAKY
 
 [$jsEngine==chakracore && $arch==x64]
-test-buffer-includes : SKIP
-test-buffer-indexof : SKIP
-test-buffer-slow : SKIP
+test-buffer-includes : PASS,FLAKY
+test-buffer-indexof : PASS,FLAKY
+test-buffer-slow : PASS,FLAKY
+
+[$jsEngine==chakracore && $system==win32]
+test-module-loading-globalpaths : PASS,FLAKY
+test-http-client-get-url : PASS,FLAKY
+
+[$jsEngine==chakracore && $system==linux]
+test-repl-sigint-nested-eval : PASS,FLAKY
+
+[$jsEngine==chakracore && $system==macos]
+test-repl-sigint-nested-eval : PASS,FLAKY
+test-vm-sigint : PASS,FLAKY
diff --git a/test/parallel/test-buffer-regression-649.js b/test/parallel/test-buffer-regression-649.js
@@ -4,13 +4,6 @@ const common = require('../common');
 const assert = require('assert');
 const SlowBuffer = require('buffer').SlowBuffer;
 
-if (common.isChakraEngine) {
-  console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
-  'because of behavior difference in treating `len` parameter of ArrayBuffer' +
-  'See https://github.com/Microsoft/ChakraCore/issues/105.');
-  return;
-}
-
 // Regression test for https://github.com/nodejs/node/issues/649.
 const len = 1422561062959;
 const message = common.bufferMaxSizeMsg;

diff --git a/test/parallel/test-buffer-sharedarraybuffer.js b/test/parallel/test-buffer-sharedarraybuffer.js
@@ -2,14 +2,7 @@
 'use strict';
 // Flags: --harmony-sharedarraybuffer
 
-const common = require('../common');
-
-if (common.isChakraEngine) {
-  console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
-          'because SharedArrayBuffer is not yet supported');
-  return;
-}
-
+require('../common');
 const assert = require('assert');
 const Buffer = require('buffer').Buffer;
 

diff --git a/test/parallel/test-domain-throw-error-then-throw-from-uncaught-exception-handler.js b/test/parallel/test-domain-throw-error-then-throw-from-uncaught-exception-handler.js
@@ -11,8 +11,8 @@ const child_process = require('child_process');
 const domain = require('domain');
 
 if (common.isChakraEngine) {
-  console.log(`1..0 # Skipped: This test is disabled for chakra engine
-    because it depends on v8-option --abort-on-uncaught-exception`);
+  common.skip('This test is disabled for chakra engine because it depends ' +
+              'on v8-option --abort-on-uncaught-exception');
   return;
 }
 

diff --git a/test/parallel/test-domain-with-abort-on-uncaught-exception.js b/test/parallel/test-domain-with-abort-on-uncaught-exception.js
@@ -27,8 +27,8 @@ const fs = require('fs');
  */
 
 if (common.isChakraEngine) {
-  console.log(`1..0 # Skipped: This test is disabled for chakra engine
-    because it depends on v8-option --abort-on-uncaught-exception`);
+  common.skip('This test is disabled for chakra engine because it depends ' +
+              'on v8-option --abort-on-uncaught-exception');
   return;
 }
 

diff --git a/test/parallel/test-preload.js b/test/parallel/test-preload.js
@@ -6,8 +6,8 @@ const path = require('path');
 const childProcess = require('child_process');
 
 if (common.isChakraEngine) {
-  console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
-  'because debugger support is not implemented yet.');
+  common.skip('This test is disabled for chakra engine because debugger ' +
+              'support is not implemented yet.');
   return;
 }
 

diff --git a/test/parallel/test-util-format-shared-arraybuffer.js b/test/parallel/test-util-format-shared-arraybuffer.js
@@ -1,14 +1,7 @@
 // Flags: --harmony_sharedarraybuffer
 
 'use strict';
-const common = require('../common');
-
-if (common.isChakraEngine) {
-  console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
-          'because SharedArrayBuffer is not yet supported');
-  return;
-}
-
+require('../common');
 const assert = require('assert');
 const util = require('util');
 

diff --git a/test/parallel/test-v8-flags.js b/test/parallel/test-v8-flags.js
@@ -5,7 +5,7 @@ const v8 = require('v8');
 const vm = require('vm');
 
 if (common.isChakraEngine) {
-  console.log('1..0 # Skipped: This test is disabled for chakra engine.');
+  common.skip('This test is disabled for chakra engine.');
   return;
 }
 

diff --git a/test/parallel/test-v8-version-tag.js b/test/parallel/test-v8-version-tag.js
@@ -4,7 +4,7 @@ const assert = require('assert');
 const v8 = require('v8');
 
 if (common.isChakraEngine) {
-  console.log('1..0 # Skipped: This test is disabled for chakra engine.');
+  common.skip('This test is disabled for chakra engine.');
   return;
 }
 

diff --git a/test/parallel/test-vm-debug-context.js b/test/parallel/test-vm-debug-context.js
@@ -26,12 +26,6 @@ const assert = require('assert');
 const vm = require('vm');
 const spawn = require('child_process').spawn;
 
-if (common.isChakraEngine) {
-  console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
-  'because debugger support is not implemented yet.');
-  return;
-}
-
 assert.throws(function() {
   vm.runInDebugContext('*');
 }, /SyntaxError/);

diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status
@@ -20,6 +20,6 @@ test-benchmark-child-process  : PASS,FLAKY
 [$system==aix]
 
 [$jsEngine==chakracore]
-test-http-regr-gh-2928 : SKIP
-test-net-GH-5504 : SKIP
-test-vm-timeout-rethrow : SKIP
+
+[$jsEngine==chakracore && $system==linux]
+test-child-process-pass-fd : PASS,FLAKY
diff --git a/test/sequential/test-domain-abort-on-uncaught.js b/test/sequential/test-domain-abort-on-uncaught.js
@@ -10,8 +10,8 @@ const domain = require('domain');
 const child_process = require('child_process');
 
 if (common.isChakraEngine) {
-  console.log(`1..0 # Skipped: This test is disabled for chakra engine
-    because it depends on v8-option --abort-on-uncaught-exception`);
+  common.skip('This test is disabled for chakra engine because it depends ' +
+              'on v8-option --abort-on-uncaught-exception');
   return;
 }