Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: skip a check in test_handle_scope
Browse files Browse the repository at this point in the history
jsrt napi doesn't implement `napi_open_escapable_handle_scope`.
When we escape handle scope twice, we should throw, but there is
no place to store the information.

Hence skipping the check for now.

PR-URL: #321
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
  • Loading branch information
kunalspathak authored and kfarnung committed Jul 6, 2017
1 parent 89800a5 commit 74c0740
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions test/addons-napi/test_handle_scope/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ testHandleScope.NewScope();

assert.ok(testHandleScope.NewScopeEscape() instanceof Object);

assert.throws(
() => {
testHandleScope.NewScopeEscapeTwice();
},
Error);
if (!common.isChakraEngine) {
assert.throws(
() => {
testHandleScope.NewScopeEscapeTwice();
},
Error);
}

assert.throws(
() => {
Expand Down

0 comments on commit 74c0740

Please sign in to comment.