Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: skip tests that fail for ChakraCore
Browse files Browse the repository at this point in the history 
Tests were marked as FLAKY in the .status files for ChakraCore because
they were failing. This commit changes the .status files to skip those
tests instead.

PR-URL: #436
Fixes: #426
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Jack Horton <jahorto@microsoft.com>
  • Loading branch information
@jaimecbernardo @kfarnung
jaimecbernardo authored and kfarnung committed Jan 11, 2018
1 parent 0c90532 commit 21fbb5e
Show file tree
Hide file tree
Showing 8 changed files with 147 additions and 131 deletions.
4 changes: 2 additions & 2 deletions test/addons-napi/addons-napi.status
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ prefix addons-napi
[$system==aix]

[$jsEngine==chakracore]
test_env_sharing/test : PASS,FLAKY
test_general/test : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test_env_sharing/test : SKIP
11 changes: 6 additions & 5 deletions test/addons/addon.status
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ prefix addons
[$system==aix]

[$jsEngine==chakracore]
async-hooks-promise/test : PASS,FLAKY
hello-world-esm/test : PASS,FLAKY
new-target/test : PASS,FLAKY
callback-scope/test : PASS,FLAKY
callback-scope/test-resolve-async : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
async-hooks-promise/test : SKIP
hello-world-esm/test : SKIP
new-target/test : SKIP
callback-scope/test : SKIP
callback-scope/test-resolve-async : SKIP
8 changes: 4 additions & 4 deletions test/async-hooks/async-hooks.status
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ prefix async-hooks
[$system==freebsd]

[$jsEngine==chakracore]
test-promise : PASS,FLAKY
test-promise.chain-promise-before-init-hooks : PASS,FLAKY
test-promise.promise-before-init-hooks : PASS,FLAKY

# These tests are failing for Node-Chakracore and should eventually be fixed
test-promise : SKIP
test-promise.chain-promise-before-init-hooks : SKIP
test-promise.promise-before-init-hooks : SKIP
42 changes: 21 additions & 21 deletions test/es-module/es-module.status
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,24 @@ prefix es-module
[true] # This section applies to all platforms

[$jsEngine==chakracore]
test-esm-addon : PASS,FLAKY
test-esm-basic-imports : PASS,FLAKY
test-esm-double-encoding : PASS,FLAKY
test-esm-encoded-path : PASS,FLAKY
test-esm-encoded-path-native : PASS,FLAKY
test-esm-example-loader : PASS,FLAKY
test-esm-forbidden-globals : PASS,FLAKY
test-esm-json : PASS,FLAKY
test-esm-loader-dependency : PASS,FLAKY
test-esm-loader-modulemap : PASS,FLAKY
test-esm-named-exports : PASS,FLAKY
test-esm-namespace : PASS,FLAKY
test-esm-ok : PASS,FLAKY
test-esm-preserve-symlinks : PASS,FLAKY
test-esm-preserve-symlinks-not-found : PASS,FLAKY
test-esm-preserve-symlinks-not-found-plain : PASS,FLAKY
test-esm-require-cache : PASS,FLAKY
test-esm-resolve-hook : PASS,FLAKY
test-esm-shebang : PASS,FLAKY
test-esm-snapshot : PASS,FLAKY
test-esm-symlink : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test-esm-basic-imports : SKIP
test-esm-double-encoding : SKIP
test-esm-encoded-path : SKIP
test-esm-encoded-path-native : SKIP
test-esm-example-loader : SKIP
test-esm-forbidden-globals : SKIP
test-esm-json : SKIP
test-esm-loader-dependency : SKIP
test-esm-loader-modulemap : SKIP
test-esm-named-exports : SKIP
test-esm-namespace : SKIP
test-esm-ok : SKIP
test-esm-preserve-symlinks : SKIP
test-esm-preserve-symlinks-not-found : SKIP
test-esm-preserve-symlinks-not-found-plain : SKIP
test-esm-require-cache : SKIP
test-esm-resolve-hook : SKIP
test-esm-shebang : SKIP
test-esm-snapshot : SKIP
test-esm-symlink : SKIP
7 changes: 3 additions & 4 deletions test/known_issues/known_issues.status
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ test-cluster-disconnect-handles: SKIP
[$system==aix]

[$jsEngine==chakracore]
test-vm-attributes-property-not-on-sandbox : PASS,FLAKY
test-vm-data-property-writable : PASS,FLAKY
test-vm-inherited_properties : PASS,FLAKY
test-vm-strict-mode : PASS,FLAKY
test-vm-attributes-property-not-on-sandbox : SKIP
test-vm-data-property-writable : SKIP
test-vm-inherited_properties : SKIP
6 changes: 3 additions & 3 deletions test/message/message.status
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ prefix message
[$system==freebsd]

[$jsEngine==chakracore]
console_low_stack_space : PASS,FLAKY
stack_overflow_async : PASS,FLAKY
unhandled_promise_trace_warnings : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
console_low_stack_space : SKIP
unhandled_promise_trace_warnings : SKIP
178 changes: 96 additions & 82 deletions test/parallel/parallel.status
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,94 +22,108 @@ test-npm-install: PASS,FLAKY
[$system==aix]

[$jsEngine==chakracore]
test-assert-checktag : PASS,FLAKY
test-async-hooks-disable-during-promise : PASS,FLAKY
test-async-hooks-enable-during-promise : PASS,FLAKY
test-async-hooks-promise : PASS,FLAKY
test-async-hooks-promise-enable-disable : PASS,FLAKY
test-async-hooks-promise-triggerid : PASS,FLAKY
test-async-wrap-getasyncid : PASS,FLAKY
test-async-wrap-promise-after-enabled : PASS,FLAKY
test-buffer-bindingobj-no-zerofill : PASS,FLAKY
test-buffer-sharedarraybuffer : PASS,FLAKY
test-child-process-promisified : PASS,FLAKY
test-cluster-inspector-debug-port : PASS,FLAKY
test-crypto-dh : PASS,FLAKY
test-crypto-dh-leak : PASS,FLAKY
test-debugger-repeat-last : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-0 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-1 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-2 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-3 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-4 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-5 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-6 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-7 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-8 : PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-9 : PASS,FLAKY
test-domain-promise : PASS,FLAKY
test-fs-promisified : PASS,FLAKY
test-fs-stat : PASS,FLAKY
test-http-pipeline-flood : PASS,FLAKY
test-http-same-map : PASS,FLAKY
test-http2-client-promisify-connect : PASS,FLAKY
test-http2-server-rst-stream : PASS,FLAKY
test-inspect-async-hook-setup-at-inspect : PASS,FLAKY
test-intl : PASS,FLAKY
test-intl-no-icu-data : PASS,FLAKY
test-memory-usage : PASS,FLAKY
test-module-main-extension-lookup : PASS,FLAKY
test-performance-function : PASS,FLAKY
test-performance-gc : PASS,FLAKY
test-process-env-symbols : PASS,FLAKY
test-promise-internal-creation : PASS,FLAKY
test-promises-unhandled-rejections : PASS,FLAKY
test-promises-unhandled-symbol-rejections : PASS,FLAKY
test-promises-warning-on-unhandled-rejection : PASS,FLAKY
test-regress-GH-12371 : PASS,FLAKY
test-repl : PASS,FLAKY
test-repl-mode : PASS,FLAKY
test-repl-pretty-custom-stack : PASS,FLAKY
test-repl-pretty-stack : PASS,FLAKY
test-repl-sigint : PASS,FLAKY
test-repl-tab-complete : PASS,FLAKY
test-string-decoder : PASS,FLAKY
test-timers-promisified : PASS,FLAKY
test-trace-event : PASS,FLAKY
test-url-domain-ascii-unicode : PASS,FLAKY
test-util : PASS,FLAKY
test-util-format-shared-arraybuffer : PASS,FLAKY
test-util-inspect-proxy : PASS,FLAKY
test-util-promisify : PASS,FLAKY
test-v8-serdes : PASS,FLAKY
test-v8-serdes-sharedarraybuffer : PASS,FLAKY
test-vm-cached-data : PASS,FLAKY
test-vm-context : PASS,FLAKY
test-vm-create-and-run-in-context : PASS,FLAKY
test-vm-debug-context : PASS,FLAKY
test-vm-global-identity : PASS,FLAKY
test-vm-low-stack-space : PASS,FLAKY
test-vm-preserves-property : PASS,FLAKY
test-vm-property-not-on-sandbox : PASS,FLAKY
test-vm-sigint : PASS,FLAKY
test-vm-sigint-existing-handler : PASS,FLAKY
test-vm-strict-mode : PASS,FLAKY
test-vm-timeout : PASS,FLAKY
test-zlib-convenience-methods : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test-assert-checktag : SKIP
test-async-hooks-disable-during-promise : SKIP
test-async-hooks-enable-during-promise : SKIP
test-async-hooks-promise : SKIP
test-async-hooks-promise-enable-disable : SKIP
test-async-hooks-promise-triggerid : SKIP
test-async-wrap-promise-after-enabled : SKIP
test-buffer-bindingobj-no-zerofill : SKIP
test-buffer-sharedarraybuffer : SKIP
test-child-process-promisified : SKIP
test-crypto-dh : SKIP
test-crypto-dh-leak : SKIP
test-domain-abort-on-uncaught : SKIP
test-domain-no-error-handler-abort-on-uncaught-0 : SKIP
test-domain-no-error-handler-abort-on-uncaught-1 : SKIP
test-domain-no-error-handler-abort-on-uncaught-2 : SKIP
test-domain-no-error-handler-abort-on-uncaught-3 : SKIP
test-domain-no-error-handler-abort-on-uncaught-4 : SKIP
test-domain-no-error-handler-abort-on-uncaught-5 : SKIP
test-domain-no-error-handler-abort-on-uncaught-6 : SKIP
test-domain-no-error-handler-abort-on-uncaught-7 : SKIP
test-domain-no-error-handler-abort-on-uncaught-8 : SKIP
test-domain-no-error-handler-abort-on-uncaught-9 : SKIP
test-domain-promise : SKIP
test-fs-promisified : SKIP
test-fs-stat : SKIP
test-http-pipeline-flood : SKIP
test-http-same-map : SKIP
test-http2-client-promisify-connect : SKIP
test-http2-server-rst-stream : SKIP
test-inspect-async-hook-setup-at-inspect : SKIP
test-intl : SKIP
test-memory-usage : SKIP
test-module-main-extension-lookup : SKIP
test-performance-function : SKIP
test-performance-gc : SKIP
test-process-env-symbols : SKIP
test-promise-internal-creation : SKIP
test-promises-unhandled-rejections : SKIP
test-promises-unhandled-symbol-rejections : SKIP
test-promises-warning-on-unhandled-rejection : SKIP
test-regress-GH-12371 : SKIP
test-repl : SKIP
test-repl-mode : SKIP
test-repl-pretty-custom-stack : SKIP
test-repl-pretty-stack : SKIP
test-repl-sigint : SKIP
test-repl-tab-complete : SKIP
test-string-decoder : SKIP
test-timers-promisified : SKIP

# ChakraCore does not support the chrome tracing framework
test-trace-event : SKIP

test-url-domain-ascii-unicode : SKIP
test-util : SKIP
test-util-format-shared-arraybuffer : SKIP
test-util-inspect-proxy : SKIP
test-util-promisify : SKIP
test-v8-serdes : SKIP
test-v8-serdes-sharedarraybuffer : SKIP
test-vm-cached-data : SKIP
test-vm-context : SKIP
test-vm-create-and-run-in-context : SKIP
test-vm-debug-context : SKIP
test-vm-global-identity : SKIP
test-vm-low-stack-space : SKIP
test-vm-preserves-property : SKIP
test-vm-property-not-on-sandbox : SKIP
test-vm-sigint : SKIP
test-vm-sigint-existing-handler : SKIP
test-vm-strict-mode : SKIP
test-vm-timeout : SKIP
test-zlib-convenience-methods : SKIP
test-vm-function-declaration : SKIP
test-vm-global-define-property : SKIP
test-vm-harmony-symbols : SKIP
test-vm-indexed-properties : SKIP
test-vm-proxies : SKIP

[$jsEngine==chakracore && $arch==x64]
test-buffer-includes : PASS,FLAKY
test-buffer-indexof : PASS,FLAKY
test-buffer-slow : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test-buffer-includes : SKIP
test-buffer-indexof : SKIP
test-buffer-slow : SKIP

[$jsEngine==chakracore && $system==win32]
test-module-loading-globalpaths : PASS,FLAKY
test-http-client-get-url : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test-module-loading-globalpaths : SKIP
test-http-client-get-url : SKIP

[$jsEngine==chakracore && $system==linux]
test-repl-sigint-nested-eval : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test-repl-sigint-nested-eval : SKIP

# https://github.com/Microsoft/ChakraCore/issues/3561
test-wasm-simple : SKIP

[$jsEngine==chakracore && $system==macos]
test-repl-sigint-nested-eval : PASS,FLAKY
test-vm-sigint : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test-repl-sigint-nested-eval : SKIP
test-vm-sigint : SKIP
# https://github.com/Microsoft/ChakraCore/issues/3561
test-wasm-simple : SKIP
22 changes: 12 additions & 10 deletions test/sequential/sequential.status
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,17 @@ test-inspector-async-hook-setup-at-signal: PASS, FLAKY
[$system==aix]

[$jsEngine==chakracore]
test-async-wrap-getasyncid : PASS,FLAKY
test-benchmark-child-process : PASS,FLAKY
test-inspector-async-hook-setup-at-inspect-brk : PASS,FLAKY
test-inspector-async-stack-traces-promise-then : PASS,FLAKY
test-inspector-async-stack-traces-set-interval : PASS,FLAKY
test-inspector-break-when-eval : PASS,FLAKY
test-inspector-scriptparsed-context : PASS,FLAKY
test-inspector-stop-profile-after-done : PASS,FLAKY
test-vm-timeout-rethrow : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test-vm-timeout-rethrow : SKIP
test-benchmark-child-process : SKIP
test-async-wrap-getasyncid : SKIP
test-inspector-async-hook-setup-at-inspect-brk : SKIP
test-inspector-async-stack-traces-promise-then : SKIP
test-inspector-async-stack-traces-set-interval : SKIP
test-inspector-break-when-eval : SKIP
test-inspector-scriptparsed-context : SKIP
test-inspector-stop-profile-after-done : SKIP

[$jsEngine==chakracore && $system==linux]
test-child-process-pass-fd : PASS,FLAKY
# These tests are failing for Node-Chakracore and should eventually be fixed
test-child-process-pass-fd : SKIP

0 comments on commit 21fbb5e

Please sign in to comment.