Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 1992a83

Browse files
kunalspathakorangemocha
kunalspathak
authored and
orangemocha
committed
deps: Updated chakracore to 1.1.0.3
Includes below bug fixes in chakracore: * Fix to chakracore that enables chakracore work on windows 7 without IE11. * field copy-prop bug fix. See Microsoft/Chakracore [release/1.1](https://github.com/Microsoft/ChakraCore/commits/release/1.1) for more details. PR-URL: #25 Reviewed-By: Jianchun Xu <Jianchun.Xu@microsoft.com> Fixes: #20
1 parent 83e078c commit 1992a83

28 files changed

+303
-125
lines changed

‎deps/chakrashim/core/CODE_OF_CONDUCT.md

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
# Contributor Code of Conduct
2+
3+
As contributors and maintainers of this project, and in the interest of
4+
fostering an open and welcoming community, we pledge to respect all people who
5+
contribute through reporting issues, posting feature requests, updating
6+
documentation, submitting pull requests or patches, and other activities.
7+
8+
We are committed to making participation in this project a harassment-free
9+
experience for everyone, regardless of level of experience, gender, gender
10+
identity and expression, sexual orientation, disability, personal appearance,
11+
body size, race, ethnicity, age, religion, or nationality. We will
12+
prioritize marginalized people's safety over marginalized people's comfort.
13+
14+
Examples of unacceptable behavior by participants include:
15+
16+
* The use of sexualized language or imagery
17+
* Personal attacks
18+
* Trolling or insulting/derogatory comments
19+
* Public or private harassment
20+
* Publishing other's private information, such as physical or electronic
21+
addresses, without explicit permission
22+
* Other unethical or unprofessional conduct
23+
24+
Project maintainers have the right _and responsibility_ to remove, edit, or
25+
reject comments, commits, code, wiki edits, issues, and other contributions
26+
that are not aligned to this Code of Conduct, or to ban temporarily or
27+
permanently any contributor for other behaviors that they deem inappropriate,
28+
threatening, offensive, or harmful.
29+
30+
By adopting this Code of Conduct, project maintainers commit themselves to
31+
fairly and consistently applying these principles to every aspect of managing
32+
this project. Project maintainers who do not follow or enforce the Code of
33+
Conduct may be permanently removed from the project team.
34+
35+
This Code of Conduct applies both within project spaces and in public spaces
36+
when an individual is representing the project or its community.
37+
38+
Instances of abusive, harassing, or otherwise unacceptable behavior may be
39+
reported by contacting us at [chakracore@microsoft.com][email]. All
40+
complaints will be reviewed and investigated and will result in a response that
41+
is deemed necessary and appropriate to the circumstances. Maintainers are
42+
obligated to maintain confidentiality with regard to the reporter of an
43+
incident.
44+
45+
This Code of Conduct is adapted from the [Contributor Covenant][homepage] version 1.3.0
46+
and [Open Code of Conduct][opencoc].
47+
48+
[email]: mailto:chakracore@microsoft.com
49+
[homepage]: http://contributor-covenant.org
50+
[version]: http://contributor-covenant.org/version/1/3/0/
51+
[opencoc]: http://todogroup.org/opencodeofconduct/

‎deps/chakrashim/core/README.md

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -4,36 +4,36 @@ ChakraCore is the core part of Chakra, the high-performance JavaScript engine th
44

55
You can stay up-to-date on progress by following the [MSEdge developer blog](http://blogs.windows.com/msedgedev/).
66

7-
## Build Status
7+
## [Build Status](https://github.com/Microsoft/ChakraCore/wiki/Build-Status)
88

99
| | __Debug__ | __Test__ | __Release__ |
1010
|:-------:|:---------:|:--------:|:-----------:|
1111
| __x86__ | [![x86debug][x86dbgicon]][x86dbglink] | [![x86test][x86testicon]][x86testlink] | [![x86release][x86relicon]][x86rellink] |
1212
| __x64__ | [![x64debug][x64dbgicon]][x64dbglink] | [![x64test][x64testicon]][x64testlink] | [![x64release][x64relicon]][x64rellink] |
1313
| __arm__ | [![armdebug][armdbgicon]][armdbglink] | [![armtest][armtesticon]][armtestlink] | [![armrelease][armrelicon]][armrellink] |
1414

15-
[x86dbgicon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x86_debug/badge/icon
16-
[x86dbglink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x86_debug/
17-
[x86testicon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x86_test/badge/icon
18-
[x86testlink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x86_test/
19-
[x86relicon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x86_release/badge/icon
20-
[x86rellink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x86_release/
21-
22-
[x64dbgicon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x64_debug/badge/icon
23-
[x64dbglink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x64_debug/
24-
[x64testicon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x64_test/badge/icon
25-
[x64testlink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x64_test/
26-
[x64relicon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x64_release/badge/icon
27-
[x64rellink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_x64_release/
28-
29-
[armdbgicon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_arm_debug/badge/icon
30-
[armdbglink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_arm_debug/
31-
[armtesticon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_arm_test/badge/icon
32-
[armtestlink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_arm_test/
33-
[armrelicon]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_arm_release/badge/icon
34-
[armrellink]: http://dotnet-ci.cloudapp.net/job/Private/job/Microsoft_ChakraCore_arm_release/
35-
36-
Note: these badges are correct but currently display on GitHub as image not found because of permissions. This will be fixed when the build jobs are public.
15+
[x86dbgicon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x86_debug/badge/icon
16+
[x86dbglink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x86_debug/
17+
[x86testicon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x86_test/badge/icon
18+
[x86testlink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x86_test/
19+
[x86relicon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x86_release/badge/icon
20+
[x86rellink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x86_release/
21+
22+
[x64dbgicon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x64_debug/badge/icon
23+
[x64dbglink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x64_debug/
24+
[x64testicon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x64_test/badge/icon
25+
[x64testlink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x64_test/
26+
[x64relicon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x64_release/badge/icon
27+
[x64rellink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_x64_release/
28+
29+
[armdbgicon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_arm_debug/badge/icon
30+
[armdbglink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_arm_debug/
31+
[armtesticon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_arm_test/badge/icon
32+
[armtestlink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_arm_test/
33+
[armrelicon]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_arm_release/badge/icon
34+
[armrellink]: http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/Microsoft_ChakraCore_arm_release/
35+
36+
Above is a table of our rolling build status. We run additional builds on a daily basis. See [Build Status](https://github.com/Microsoft/ChakraCore/wiki/Build-Status) for the status of all builds.
3737

3838
## Security
3939

@@ -75,10 +75,10 @@ Contributions to ChakraCore are welcome. Here is how you can contribute to Chak
7575
* [Submit pull requests](https://github.com/Microsoft/ChakraCore/pulls) for bug fixes and features and discuss existing proposals
7676
* Chat about [@ChakraCore](https://twitter.com/ChakraCore) on Twitter
7777

78-
Please refer to [Contribution guidelines](CONTRIBUTING.md) for more details.
78+
Please refer to [Contribution guidelines](CONTRIBUTING.md) and the [Code of Conduct](CODE_OF_CONDUCT.md) for more details.
7979

8080
## Roadmap
8181
For details on our planned features and future direction please refer to our [roadmap](https://github.com/Microsoft/ChakraCore/wiki/Roadmap).
8282

8383
## Contact us
84-
For questions about ChakraCore, please open an [issue](https://github.com/Microsoft/ChakraCore/issues/new) and prefix the issue title with [Question].
84+
For questions about ChakraCore, please open an [issue](https://github.com/Microsoft/ChakraCore/issues/new) and prefix the issue title with [Question].

‎deps/chakrashim/core/jenkins.check_copyright.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626

2727
file_name = sys.argv[1]
2828
if not os.path.isfile(file_name):
29-
print "File does not exist:", file_name
30-
exit(1)
29+
print "File does not exist:", file_name, "(not neccesarily an error)"
30+
exit(0)
3131

3232
with open(file_name, 'r') as sourcefile:
3333
for x in range(0,len(copyright_lines)):

‎deps/chakrashim/core/lib/Backend/Encoder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ void Encoder::RecordInlineeFrame(Func* inlinee, uint32 currentOffset)
592592
{
593593
// The only restriction for not supporting loop bodies is that inlinee frame map is created on FunctionEntryPointInfo & not
594594
// the base class EntryPointInfo.
595-
if (!this->m_func->IsSimpleJit())
595+
if (!this->m_func->IsLoopBody() && !this->m_func->IsSimpleJit())
596596
{
597597
InlineeFrameRecord* record = nullptr;
598598
if (inlinee->frameInfo && inlinee->m_hasInlineArgsOpt)

‎deps/chakrashim/core/lib/Backend/Func.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,14 +138,14 @@ Func::Func(JitArenaAllocator *alloc, CodeGenWorkItem* workItem, const Js::Functi
138138
m_workItem->GetEntryPoint()->SetHasJittedStackClosure();
139139
}
140140

141-
if (m_jnFunction->GetDoBackendArgumentsOptimization() && !m_jnFunction->GetHasTry())
142-
{
143-
// doBackendArgumentsOptimization bit is set when there is no eval inside a function
144-
// as determined by the bytecode generator.
145-
SetHasStackArgs(true);
146-
}
147141
if (m_workItem->Type() == JsFunctionType)
148142
{
143+
if (m_jnFunction->GetDoBackendArgumentsOptimization() && !m_jnFunction->GetHasTry())
144+
{
145+
// doBackendArgumentsOptimization bit is set when there is no eval inside a function
146+
// as determined by the bytecode generator.
147+
SetHasStackArgs(true);
148+
}
149149
if (doStackNestedFunc && m_jnFunction->GetNestedCount() != 0)
150150
{
151151
Assert(!(this->IsJitInDebugMode() && !m_jnFunction->GetUtf8SourceInfo()->GetIsLibraryCode()));

‎deps/chakrashim/core/lib/Backend/GlobOptFields.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,6 +1607,7 @@ GlobOpt::CreateFieldSrcValue(PropertySym * sym, PropertySym * originalSym, IR::O
16071607
// We don't clear the value when we kill the field.
16081608
// Clear it to make sure we don't use the old value.
16091609
this->blockData.symToValueMap->Clear(sym->m_id);
1610+
this->blockData.symToValueMap->Clear(originalSym->m_id);
16101611
}
16111612

16121613
Assert((*ppOpnd)->AsSymOpnd()->m_sym == sym || this->IsLoopPrePass());

‎deps/chakrashim/core/lib/Backend/InliningDecider.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ Js::FunctionInfo *InliningDecider::Inline(Js::FunctionBody *const inliner, Js::F
190190
Js::FunctionProxy * proxy = functionInfo->GetFunctionProxy();
191191
if (proxy && proxy->IsFunctionBody())
192192
{
193-
if (isLoopBody && PHASE_OFF(Js::InlineInJitLoopBodyPhase, this->topFunc))
193+
if (isLoopBody && !PHASE_ON(Js::InlineInJitLoopBodyPhase, this->topFunc))
194194
{
195195
INLINE_TESTTRACE_VERBOSE(L"INLINING: Skip Inline: Jit loop body: %s (%s)\n", this->topFunc->GetDisplayName(),
196196
this->topFunc->GetDebugNumberSet(debugStringBuffer));

‎deps/chakrashim/core/lib/Backend/NativeCodeGenerator.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1708,6 +1708,7 @@ NativeCodeGenerator::GatherCodeGenData(
17081708
Assert(functionBody);
17091709
Assert(jitTimeData);
17101710
Assert(IsInlinee == !!runtimeData);
1711+
Assert(!IsInlinee || !inliningDecider.GetIsLoopBody());
17111712
Assert(topFunctionBody != nullptr && (!entryPoint->GetWorkItem() || entryPoint->GetWorkItem()->GetFunctionBody() == topFunctionBody));
17121713
Assert(objTypeSpecFldInfoList != nullptr);
17131714

‎deps/chakrashim/core/lib/Parser/CharClassifier.cpp

Lines changed: 23 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -619,28 +619,36 @@ void Js::CharClassifier::initClassifier(ScriptContext * scriptContext, CharClass
619619
if (es6ModeNeeded)
620620
{
621621
HRESULT hr = globalizationAdapter->EnsureDataTextObjectsInitialized(globLibrary);
622+
// Failed to load windows.globalization.dll or jsintl.dll. No unicodeStatics support
623+
// in that case.
622624
if (FAILED(hr))
623625
{
624-
AssertMsg(false, "Failed to initialize COM interfaces, verify correct version of globalization dll is used.");
625-
JavascriptError::MapAndThrowError(scriptContext, hr);
626-
}
627-
628-
this->winGlobCharApi = globalizationAdapter->GetUnicodeStatics();
629-
if (this->winGlobCharApi == nullptr)
630-
{
631-
// No fallback mode, then assert
632-
if (es6FallbackMode == CharClassifierModes::ES6)
633-
{
634-
AssertMsg(false, "Windows::Data::Text::IUnicodeCharactersStatics not initialized");
635-
//Fallback to ES5 just in case for fre builds.
636-
es6FallbackMode = CharClassifierModes::ES5;
637-
}
638626
if (isES6UnicodeVerboseEnabled)
639627
{
640628
Output::Print(L"Windows::Data::Text::IUnicodeCharactersStatics not initialized\r\n");
641629
}
642-
//Default to non-es6
643630
es6Supported = false;
631+
es6FallbackMode = CharClassifierModes::ES5;
632+
}
633+
else
634+
{
635+
this->winGlobCharApi = globalizationAdapter->GetUnicodeStatics();
636+
if (this->winGlobCharApi == nullptr)
637+
{
638+
// No fallback mode, then assert
639+
if (es6FallbackMode == CharClassifierModes::ES6)
640+
{
641+
AssertMsg(false, "Windows::Data::Text::IUnicodeCharactersStatics not initialized");
642+
//Fallback to ES5 just in case for fre builds.
643+
es6FallbackMode = CharClassifierModes::ES5;
644+
}
645+
if (isES6UnicodeVerboseEnabled)
646+
{
647+
Output::Print(L"Windows::Data::Text::IUnicodeCharactersStatics not initialized\r\n");
648+
}
649+
//Default to non-es6
650+
es6Supported = false;
651+
}
644652
}
645653
}
646654
#else

‎deps/chakrashim/core/lib/Runtime/Base/DelayLoadLibrary.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,11 @@ namespace Js
176176
return E_NOTIMPL;
177177
}
178178

179+
bool DelayLoadWindowsGlobalization::HasGlobalizationDllLoaded()
180+
{
181+
return this->hasGlobalizationDllLoaded;
182+
}
183+
179184
HRESULT DelayLoadWindowsGlobalization::DllGetActivationFactory(
180185
__in HSTRING activatibleClassId,
181186
__out IActivationFactory** factory)
@@ -268,6 +273,11 @@ namespace Js
268273
m_hModule = LoadLibraryEx(GetWin7LibraryName(), nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32);
269274
}
270275

276+
// Set the flag depending on Windows.globalization.dll or jsintl.dll was loaded successfully or not
277+
if (m_hModule != nullptr)
278+
{
279+
hasGlobalizationDllLoaded = true;
280+
}
271281
this->winRTStringLibrary = winRTStringLibrary;
272282
this->winRTStringsPresent = GetFunction("WindowsDuplicateString") != nullptr;
273283
}

‎deps/chakrashim/core/lib/Runtime/Base/DelayLoadLibrary.h

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,13 +166,15 @@ namespace Js
166166
PFNCWDllGetActivationFactory m_pfnFNCWDllGetActivationFactory;
167167

168168
Js::DelayLoadWinRtString *winRTStringLibrary;
169-
BOOL winRTStringsPresent;
169+
bool winRTStringsPresent;
170+
bool hasGlobalizationDllLoaded;
170171

171172
public:
172173
DelayLoadWindowsGlobalization() : DelayLoadWinRtString(),
173174
m_pfnFNCWDllGetActivationFactory(nullptr),
174175
winRTStringLibrary(nullptr),
175-
winRTStringsPresent(false) { }
176+
winRTStringsPresent(false),
177+
hasGlobalizationDllLoaded(false) { }
176178

177179
virtual ~DelayLoadWindowsGlobalization() { }
178180

@@ -187,6 +189,7 @@ namespace Js
187189
void Ensure(Js::DelayLoadWinRtString *winRTStringLibrary);
188190

189191
HRESULT DllGetActivationFactory(__in HSTRING activatibleClassId, __out IActivationFactory** factory);
192+
bool HasGlobalizationDllLoaded();
190193

191194
HRESULT WindowsCreateString(_In_reads_opt_(length) const WCHAR * sourceString, UINT32 length, _Outptr_result_maybenull_ _Result_nullonfailure_ HSTRING * string) override;
192195
HRESULT WindowsCreateStringReference(_In_reads_opt_(length+1) const WCHAR * sourceString, UINT32 length, _Out_ HSTRING_HEADER * header, _Outptr_result_maybenull_ _Result_nullonfailure_ HSTRING * string) override;

‎deps/chakrashim/core/lib/Runtime/Base/ScriptContext.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5239,6 +5239,17 @@ void ScriptContext::RegisterPrototypeChainEnsuredToHaveOnlyWritableDataPropertie
52395239
return false;
52405240
}
52415241

5242+
bool ScriptContext::IsIntlEnabled()
5243+
{
5244+
if (GetConfig()->IsIntlEnabled())
5245+
{
5246+
// This will try to load globalization dlls if not already loaded.
5247+
Js::DelayLoadWindowsGlobalization* globLibrary = GetThreadContext()->GetWindowsGlobalizationLibrary();
5248+
return globLibrary->HasGlobalizationDllLoaded();
5249+
}
5250+
return false;
5251+
}
5252+
52425253

52435254
#ifdef INLINE_CACHE_STATS
52445255
void ScriptContext::LogCacheUsage(Js::PolymorphicInlineCache *cache, bool isGetter, Js::PropertyId propertyId, bool hit, bool collision)

‎deps/chakrashim/core/lib/Runtime/Base/ScriptContext.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -913,6 +913,7 @@ namespace Js
913913
void RestoreRegexStacks(UnifiedRegex::RegexStacks *const contStack);
914914

915915
void InitializeGlobalObject();
916+
bool IsIntlEnabled();
916917
JavascriptLibrary* GetLibrary() const { return javascriptLibrary; }
917918
const JavascriptLibraryBase* GetLibraryBase() const { return javascriptLibrary->GetLibraryBase(); }
918919
#if DBG

‎deps/chakrashim/core/lib/Runtime/Language/JavascriptOperators.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4380,9 +4380,9 @@ namespace Js
43804380
(Js::JavascriptNumber *)buffer), scriptContext, flags, dValue);
43814381
#endif
43824382
}
4383-
BOOL JavascriptOperators::OP_Memcopy(Var dstInstance, int32 dstStart, Var srcInstance, int32 srcStart, uint32 length, ScriptContext* scriptContext)
4383+
BOOL JavascriptOperators::OP_Memcopy(Var dstInstance, int32 dstStart, Var srcInstance, int32 srcStart, int32 length, ScriptContext* scriptContext)
43844384
{
4385-
if (length == 0)
4385+
if (length <= 0)
43864386
{
43874387
return true;
43884388
}
@@ -4481,9 +4481,9 @@ namespace Js
44814481
return returnValue;
44824482
}
44834483

4484-
BOOL JavascriptOperators::OP_Memset(Var instance, int32 start, Var value, uint32 length, ScriptContext* scriptContext)
4484+
BOOL JavascriptOperators::OP_Memset(Var instance, int32 start, Var value, int32 length, ScriptContext* scriptContext)
44854485
{
4486-
if (length == 0)
4486+
if (length <= 0)
44874487
{
44884488
return true;
44894489
}

‎deps/chakrashim/core/lib/Runtime/Language/JavascriptOperators.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,8 @@ namespace Js
318318
static Var OP_DeleteElementI(Var instance, Var aElementIndex, ScriptContext* scriptContext, PropertyOperationFlags propertyOperationFlags = PropertyOperation_None);
319319
static Var OP_DeleteElementI_UInt32(Var instance, uint32 aElementIndex, ScriptContext* scriptContext, PropertyOperationFlags propertyOperationFlags = PropertyOperation_None);
320320
static Var OP_DeleteElementI_Int32(Var instance, int aElementIndex, ScriptContext* scriptContext, PropertyOperationFlags propertyOperationFlags = PropertyOperation_None);
321-
static BOOL OP_Memset(Var instance, int32 start, Var value, uint32 length, ScriptContext* scriptContext);
322-
static BOOL OP_Memcopy(Var dstInstance, int32 dstStart, Var srcInstance, int32 srcStart, uint32 length, ScriptContext* scriptContext);
321+
static BOOL OP_Memset(Var instance, int32 start, Var value, int32 length, ScriptContext* scriptContext);
322+
static BOOL OP_Memcopy(Var dstInstance, int32 dstStart, Var srcInstance, int32 srcStart, int32 length, ScriptContext* scriptContext);
323323
static Var OP_GetLength(Var instance, ScriptContext* scriptContext);
324324
static Var OP_GetThis(Var thisVar, int moduleID, ScriptContext* scriptContext);
325325
static Var OP_GetThisNoFastPath(Var thisVar, int moduleID, ScriptContext* scriptContext);

0 commit comments

Comments
 (0)