Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 0cd4cb8

Browse files
author
Jianchun Xu
committed
gyp: revert incorrect quote_cmd fix
Previously I had created a gyp tool fix to quote gyp action command: microsoft/node-v0.12#1 It looks some related gyp code have changed. The fix is now incorrect. cmd[0] contains both the action command and its arguments and the fix quoted it to `"some_command arg_list"`. gyp now generates a "call" to invoke the action, and it is invalid to `call "some_command arg_list"`. The right approach is probably for people to ensure some_command is correctly quoted in gyp file, rather than adding quote in gyp tool. Anyway, the old issue does not exist now. Previously Node.js gyp action command was `<(python)`, it is now `python`. So quotes no longer needed. PR-URL: #52 Reviewed-By: Sandeep Agarwal <Agarwal.Sandeep@microsoft.com>
1 parent c864edf commit 0cd4cb8

File tree

2 files changed

+0
-4
lines changed
  • deps/npm/node_modules/node-gyp/gyp/pylib/gyp/generator
  • tools/gyp/pylib/gyp/generator

2 files changed

+0
-4
lines changed

deps/npm/node_modules/node-gyp/gyp/pylib/gyp/generator/msvs.py

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tools/gyp/pylib/gyp/generator/msvs.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,8 +354,6 @@ def _BuildCommandLineForRuleRaw(spec, cmd, cygwin_shell, has_input_path,
354354
command = ['type']
355355
else:
356356
command = [cmd[0].replace('/', '\\')]
357-
if quote_cmd:
358-
command = ['"%s"' % i for i in command]
359357
# Add call before command to ensure that commands can be tied together one
360358
# after the other without aborting in Incredibuild, since IB makes a bat
361359
# file out of the raw command string, and some commands (like python) are

0 commit comments

Comments
 (0)