This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Previously I had created a gyp tool fix to quote gyp action command: microsoft/node-v0.12#1 It looks some related gyp code have changed. The fix is now incorrect. cmd[0] contains both the action command and its arguments and the fix quoted it to `"some_command arg_list"`. gyp now generates a "call" to invoke the action, and it is invalid to `call "some_command arg_list"`. The right approach is probably for people to ensure some_command is correctly quoted in gyp file, rather than adding quote in gyp tool. Anyway, the old issue does not exist now. Previously Node.js gyp action command was `<(python)`, it is now `python`. So quotes no longer needed. PR-URL: #52 Reviewed-By: Sandeep Agarwal <Agarwal.Sandeep@microsoft.com>
- Loading branch information