Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
gyp: revert incorrect quote_cmd fix
Browse files Browse the repository at this point in the history
Previously I had created a gyp tool fix to quote gyp action
command: microsoft/node-v0.12#1

It looks some related gyp code have changed. The fix is now incorrect.
cmd[0] contains both the action command and its arguments and the fix
quoted it to `"some_command arg_list"`. gyp now generates a "call" to
invoke the action, and it is invalid to `call "some_command arg_list"`.

The right approach is probably for people to ensure some_command is
correctly quoted in gyp file, rather than adding quote in gyp tool.

Anyway, the old issue does not exist now. Previously Node.js gyp action
command was `<(python)`, it is now `python`. So quotes no longer needed.

PR-URL: #52
Reviewed-By: Sandeep Agarwal <Agarwal.Sandeep@microsoft.com>
  • Loading branch information
Jianchun Xu committed Apr 6, 2016
1 parent c864edf commit 0cd4cb8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions tools/gyp/pylib/gyp/generator/msvs.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,6 @@ def _BuildCommandLineForRuleRaw(spec, cmd, cygwin_shell, has_input_path,
command = ['type']
else:
command = [cmd[0].replace('/', '\\')]
if quote_cmd:
command = ['"%s"' % i for i in command]
# Add call before command to ensure that commands can be tied together one
# after the other without aborting in Incredibuild, since IB makes a bat
# file out of the raw command string, and some commands (like python) are
Expand Down

0 comments on commit 0cd4cb8

Please sign in to comment.