build: also intercept libnode.dll in the delay-load hook

Covers addons linked against a shared-library Node import lib. In this
repo's own build the generated import library is NAME NODE.EXE, so the
new name is inert here; /ignore:4199 silences LNK4199 for whichever of
the two names an import table does not reference (node-gyp does the
same).

Author: hexbinoct

CMakeLists.txt

@@ -44,9 +44,13 @@ function(add_node_api_cts_addon ADDON_NAME)
     # Delay-load the node.exe imports and resolve them against the host
     # process at runtime, so the addons can be loaded by any Node-API host
     # executable regardless of its file name (the node-gyp approach).
+    # libnode.dll covers addons linked against a shared-library Node build;
+    # /ignore:4199 silences the warning for whichever of the two names the
+    # import library does not reference (node-gyp does the same).
     target_sources(${ADDON_NAME} PRIVATE ${PROJECT_SOURCE_DIR}/src/win_delay_load_hook.cc)
     target_link_libraries(${ADDON_NAME} PRIVATE delayimp)
-    target_link_options(${ADDON_NAME} PRIVATE "/DELAYLOAD:NODE.EXE")
+    target_link_options(${ADDON_NAME} PRIVATE
+      "/DELAYLOAD:NODE.EXE" "/DELAYLOAD:LIBNODE.DLL" "/ignore:4199")
   endif()
   target_compile_features(${ADDON_NAME} PRIVATE cxx_std_17)
   target_compile_definitions(${ADDON_NAME} PRIVATE ADDON_NAME=${ADDON_NAME})

src/win_delay_load_hook.cc

@@ -1,8 +1,8 @@
 /*
  * When this file is linked to a DLL, it sets up a delay-load hook that
- * intervenes when the DLL is trying to load 'node.exe' dynamically. Instead
- * of trying to locate the .exe file it'll just return a handle to the
- * process image.
+ * intervenes when the DLL is trying to load 'node.exe' or 'libnode.dll'
+ * dynamically. Instead of trying to locate the file it'll just return a
+ * handle to the process image (or to libnode.dll if the host loaded one).
  *
  * This allows the test addons to load into any Node-API host executable,
  * regardless of its file name. Same approach as node-gyp's
@@ -25,7 +25,8 @@ static FARPROC WINAPI load_exe_hook(unsigned int event, DelayLoadInfo* info) {
   if (event != dliNotePreLoadLibrary)
     return NULL;
 
-  if (_stricmp(info->szDll, "node.exe") != 0)
+  if (_stricmp(info->szDll, "node.exe") != 0 &&
+      _stricmp(info->szDll, "libnode.dll") != 0)
     return NULL;
 
   // Prefer libnode.dll to support a Node.js built as a shared library.