split test_dataview SharedArrayBuffer cases behind a feature flag

Author: bavulapati

implementors/node/features.js

@@ -2,7 +2,7 @@
 // Each key corresponds to a NODE_API_EXPERIMENTAL_HAS_* compile-time macro.
 // Other implementors should set unsupported features to false or omit them.
 
-const [major, minor] = process.version.slice(1).split('.').map(Number);
+const [major, minor, patch] = process.version.slice(1).split(".").map(Number);
 
 globalThis.experimentalFeatures = {
   // node_api_is_sharedarraybuffer and node_api_create_sharedarraybuffer were
@@ -12,4 +12,11 @@ globalThis.experimentalFeatures = {
   createObjectWithProperties: true,
   setPrototype: true,
   postFinalizer: true,
+  // napi_create_dataview accepts a SharedArrayBuffer-backed buffer only since
+  // Node.js v24.13.1 and v25.4.0 (nodejs/node#60473). It was not backported to
+  // v20.x or v22.x, where such calls fail with "invalid argument".
+  dataviewSharedArrayBuffer:
+    major > 25 ||
+    (major === 25 && minor >= 4) ||
+    (major === 24 && (minor > 13 || (minor === 13 && patch >= 1))),
 };

tests/js-native-api/test_dataview/test.js

@@ -15,32 +15,10 @@ const test_dataview = loadAddon("test_dataview");
   );
 }
 
-// Test for creating dataview with SharedArrayBuffer
-{
-  const buffer = new SharedArrayBuffer(128);
-  const template = new DataView(buffer);
-
-  const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
-  assert.ok(
-    theDataview instanceof DataView,
-    `Expect ${theDataview} to be a DataView`,
-  );
-
-  assert.strictEqual(template.buffer, theDataview.buffer);
-}
-
 // Test for creating dataview with ArrayBuffer and invalid range
 {
   const buffer = new ArrayBuffer(128);
   assert.throws(() => {
     test_dataview.CreateDataView(buffer, 10, 200);
   }, RangeError);
 }
-
-// Test for creating dataview with SharedArrayBuffer and invalid range
-{
-  const buffer = new SharedArrayBuffer(128);
-  assert.throws(() => {
-    test_dataview.CreateDataView(buffer, 10, 200);
-  }, RangeError);
-}

tests/js-native-api/test_dataview/test_sharedarraybuffer.js

@@ -0,0 +1,32 @@
+"use strict";
+
+// napi_create_dataview accepts a SharedArrayBuffer-backed buffer only on newer
+// Node.js releases (see implementors/node/features.js).
+if (!experimentalFeatures.dataviewSharedArrayBuffer) {
+  skipTest();
+}
+
+// Testing api calls for dataview backed by a SharedArrayBuffer
+const test_dataview = loadAddon("test_dataview");
+
+// Test for creating dataview with SharedArrayBuffer
+{
+  const buffer = new SharedArrayBuffer(128);
+  const template = new DataView(buffer);
+
+  const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
+  assert.ok(
+    theDataview instanceof DataView,
+    `Expect ${theDataview} to be a DataView`,
+  );
+
+  assert.strictEqual(template.buffer, theDataview.buffer);
+}
+
+// Test for creating dataview with SharedArrayBuffer and invalid range
+{
+  const buffer = new SharedArrayBuffer(128);
+  assert.throws(() => {
+    test_dataview.CreateDataView(buffer, 10, 200);
+  }, RangeError);
+}