doc: add support info #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support info as per: https://github.com/nodejs/package-maintenance/blob/main/docs/PACKAGE-SUPPORT.md Signed-off-by: Michael Dawson <mdawson@devrus.com>
This was referenced Nov 24, 2020
Closed
KevinEady
reviewed
Nov 25, 2020
There was a problem hiding this comment.
According to Integration into package.json, it says:
In all of these cases
package-support.json(or your alternative filename) should be included in yourfilesarray, or.npmignoreconfigured to avoid excluding it.
Should this be done on this PR as well...?
KevinEady
reviewed
Nov 25, 2020
package-support.json
Outdated
| { | ||
| "version": "*", | ||
| "target": { | ||
| "node": "lts" |
There was a problem hiding this comment.
According to node namespace, should this be active? Since we support node 10,12,14,15 (whereas lts is only 10,12)
There was a problem hiding this comment.
LTS is now 10,12,14, but regardless good point.
legendecas
approved these changes
Nov 29, 2020
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
* doc: add support info PR-URL: nodejs/node-addon-api#843 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
* doc: add support info PR-URL: nodejs/node-addon-api#843 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
* doc: add support info PR-URL: nodejs/node-addon-api#843 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
* doc: add support info PR-URL: nodejs/node-addon-api#843 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support info as per:
https://github.com/nodejs/package-maintenance/blob/main/docs/PACKAGE-SUPPORT.md
Signed-off-by: Michael Dawson mdawson@devrus.com