build: add incremental clang-format checks #819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
clang-format
branch
3 times, most recently
from
d4e7093
to
cb0764a
Compare
|
Lets talk about this in the next Meeting |
|
Need to separate the linting step from build steps so that we can see the linting result separated from build/test results. |
legendecas
force-pushed
the
clang-format
branch
from
cb0764a
to
f9646d8
Compare
legendecas
force-pushed
the
clang-format
branch
3 times, most recently
from
b2b26b1
to
427fc4a
Compare
|
It seems like actions were not enabled for those not merged GitHub workflow action files. Please checkout https://github.com/legendecas/node-addon-api/runs/1337409208?check_suite_focus=true for reference. |
legendecas
force-pushed
the
clang-format
branch
from
427fc4a
to
bb265e8
Compare
gabrielschulhof
approved these changes
Nov 13, 2020
gabrielschulhof
pushed a commit
that referenced
this pull request
Nov 17, 2020
PR-URL: #819 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Landed in 8fb5820. |
Superlokkus
pushed a commit
to Superlokkus/node-addon-api
that referenced
this pull request
Nov 20, 2020
PR-URL: nodejs#819 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#819 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#819 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#819 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#819 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-clang-format only check lines modified between two refs.
Fixes: #543