Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use async/await for gc #773

Closed
wants to merge 5 commits into from
Closed

test: use async/await for gc #773

wants to merge 5 commits into from

Commits on Jul 26, 2020

  1. test: string tests together 

    * Use promises and async/await to ensure that one test finishes before
  another one starts. This prevents errors thrown in one test from
  appearing to originate from another test.

* Perform garbage collection consistently, via `testUtil.runGCTests()`,
  to ensure that it is performed correctly and that its results are
  awaited.
    Gabriel Schulhof committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    5d36882 View commit details
    Browse the repository at this point in the history

  2. remove async/await pairs where a promise could be returned 

    This reduces the number of promises created internally
    Gabriel Schulhof committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    506b995 View commit details
    Browse the repository at this point in the history

  3. remove unused reject()

    Gabriel Schulhof committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    a152387 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. remove race from tsfn sum test

    Gabriel Schulhof committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    5ba003c View commit details
    Browse the repository at this point in the history

  2. remove cancel test

    Gabriel Schulhof committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    7292064 View commit details
    Browse the repository at this point in the history