Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add napi_finalize override to ObjectWrap #515

Closed
wants to merge 6 commits into from
Closed

Add napi_finalize override to ObjectWrap #515

wants to merge 6 commits into from

Commits on Jul 19, 2019

  1. Adds Napi::ObjectWrap::OverrideFinalizeCallback and documentation. Al… 

    …lows for

user defined napi_finalize finalzier callbacks; addressing advanced cleanup
senarios with opt-in complexity closer to the N-API lib.
    @mikepricedev
    mikepricedev committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    325f92b View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Updates PR nodejs#515 to implement virutal ObjectWrap::Finalize outlined 

    nodejs#515 (comment)

Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    @mikepricedev
    mikepricedev and Gabriel Schulhof committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    d4f99f7 View commit details
    Browse the repository at this point in the history

  2. Updates ObjectWrap::Finalize documention and fixes 

    formatting.

Todo: Add ObjectWrap::Finalize test.

Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    @mikepricedev
    mikepricedev and Gabriel Schulhof committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    03a235b View commit details
    Browse the repository at this point in the history

  3. Adds ObjectWrap::Finalize test. 

    Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    @mikepricedev
    mikepricedev and Gabriel Schulhof committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    cf5a57e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Fixes style and minor semantic variations. 

    Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    @mikepricedev
    mikepricedev and Gabriel Schulhof committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    9dcc324 View commit details
    Browse the repository at this point in the history

  2. Adds virtual dtor to ObjectWrap and updates implementation of 

    ObjectWrap::Finalize env param outlinted here:
nodejs#515 (comment)

Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>>
    @mikepricedev
    3 people committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    d19ba0f View commit details
    Browse the repository at this point in the history